Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setNetworkTimeout checks for SQLPermission before proceeding #255

Merged

Conversation

xiangyushawn
Copy link
Contributor

as be mentioned by @mrotteveel as well on this page, setNetworkTimeout method needs to check for permission.

@@ -4663,6 +4664,20 @@ public void setNetworkTimeout(Executor executor,
}

checkClosed();

// check for callAbort permission

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong permission in comment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, comment is fixed.

@codecov-io
Copy link

codecov-io commented Apr 18, 2017

Codecov Report

Merging #255 into dev will decrease coverage by 0.04%.
The diff coverage is 11.11%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #255      +/-   ##
============================================
- Coverage     33.77%   33.73%   -0.05%     
+ Complexity     1522     1516       -6     
============================================
  Files           101      101              
  Lines         23600    23609       +9     
  Branches       3876     3877       +1     
============================================
- Hits           7972     7964       -8     
- Misses        14061    14070       +9     
- Partials       1567     1575       +8
Flag Coverage Δ Complexity Δ
#JDBC41 33.58% <11.11%> (-0.07%) 1508 <0> (-3)
#JDBC42 33.63% <11.11%> (+0.02%) 1511 <0> (-8) ⬇️
Impacted Files Coverage Δ Complexity Δ
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 41.16% <11.11%> (-0.12%) 228 <0> (ø)
src/main/java/microsoft/sql/DateTimeOffset.java 37.14% <0%> (-2.86%) 8% <0%> (-2%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 26.33% <0%> (-1.79%) 46% <0%> (-3%)
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 44.94% <0%> (-1.13%) 16% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 25.13% <0%> (+0.04%) 178% <0%> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 45.05% <0%> (+0.07%) 183% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1f88c5...46c9f1c. Read the comment docs.

@brettwooldridge
Copy link
Contributor

Looks good to me.

@Suraiya-Hameed Suraiya-Hameed requested review from v-nisidh and removed request for v-nisidh April 26, 2017 23:15
@Suraiya-Hameed Suraiya-Hameed merged commit 616472b into microsoft:dev Apr 26, 2017
@xiangyushawn xiangyushawn deleted the set-network-timeout-permission branch April 26, 2017 23:58
@v-nisidh v-nisidh added this to the 6.1.7 milestone Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants