-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setNetworkTimeout checks for SQLPermission before proceeding #255
setNetworkTimeout checks for SQLPermission before proceeding #255
Conversation
@@ -4663,6 +4664,20 @@ public void setNetworkTimeout(Executor executor, | |||
} | |||
|
|||
checkClosed(); | |||
|
|||
// check for callAbort permission |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong permission in comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you, comment is fixed.
Codecov Report
@@ Coverage Diff @@
## dev #255 +/- ##
============================================
- Coverage 33.77% 33.73% -0.05%
+ Complexity 1522 1516 -6
============================================
Files 101 101
Lines 23600 23609 +9
Branches 3876 3877 +1
============================================
- Hits 7972 7964 -8
- Misses 14061 14070 +9
- Partials 1567 1575 +8
Continue to review full report at Codecov.
|
Looks good to me. |
as be mentioned by @mrotteveel as well on this page, setNetworkTimeout method needs to check for permission.