Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching mvn dependencies for Appveyor #320

Merged
merged 4 commits into from
Jun 5, 2017
Merged

Caching mvn dependencies for Appveyor #320

merged 4 commits into from
Jun 5, 2017

Conversation

ahmad-ibra
Copy link

This is done to speed up builds

This is done to speed up builds
@codecov-io
Copy link

codecov-io commented May 30, 2017

Codecov Report

Merging #320 into RTW_6.2.0 will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             RTW_6.2.0    #320      +/-   ##
==============================================
- Coverage        37.17%   37.1%   -0.07%     
+ Complexity        1670    1666       -4     
==============================================
  Files              103     103              
  Lines            23663   23663              
  Branches          3918    3918              
==============================================
- Hits              8796    8781      -15     
- Misses           13278   13296      +18     
+ Partials          1589    1586       -3
Flag Coverage Δ Complexity Δ
#JDBC41 36.99% <ø> (-0.05%) 1658 <ø> (-6)
#JDBC42 37.01% <ø> (-0.03%) 1662 <ø> (+2)
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 41.57% <0%> (-4.5%) 14% <0%> (-3%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 29.43% <0%> (-0.68%) 56% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 26.86% <0%> (-0.38%) 184% <0%> (-3%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 45.78% <0%> (-0.11%) 0% <0%> (ø)
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 43.23% <0%> (+0.08%) 254% <0%> (+2%) ⬆️
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 48.93% <0%> (+0.14%) 210% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8f677e...a662f66. Read the comment docs.

Copy link
Contributor

@v-nisidh v-nisidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check with new cache settings. Run couple of times if you able to see improvement then use new settings.

@@ -7,10 +7,13 @@ environment:

services:
- mssql2016

cache:
- C:\Users\appveyor\.m2 -> pom.xml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be directory caching. By following snippet it will cache whole directory.

cache:
  directories:
    - $HOME/.m2

or

cache:
 - $HOME/.m2

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing to $HOME didnt work.

With that update, appveryor can't find the cache, downloads all maven dependencies, and then creates a new build cache on every build.

Reverting back to original implementation

@ahmad-ibra ahmad-ibra merged commit f393f42 into microsoft:RTW_6.2.0 Jun 5, 2017
@ahmad-ibra ahmad-ibra deleted the AppVeyor_Cache branch June 5, 2017 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants