Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use StandardCharsets.US_ASCII in favour of string #855

Merged
merged 1 commit into from
Oct 27, 2018

Conversation

simon04
Copy link
Contributor

@simon04 simon04 commented Oct 26, 2018

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 26, 2018

Codecov Report

Merging #855 into dev will increase coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##               dev     #855      +/-   ##
===========================================
+ Coverage     48.6%   48.64%   +0.04%     
- Complexity    2796     2798       +2     
===========================================
  Files          116      116              
  Lines        27885    27882       -3     
  Branches      4651     4651              
===========================================
+ Hits         13553    13563      +10     
+ Misses       12124    12108      -16     
- Partials      2208     2211       +3
Flag Coverage Δ Complexity Δ
#JDBC42 48.22% <0%> (+0.12%) 2759 <0> (+8) ⬆️
#JDBC43 48.42% <0%> (-0.05%) 2781 <0> (-10)
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 62.45% <0%> (-0.01%) 0 <0> (ø)
...va/com/microsoft/sqlserver/jdbc/SQLServerClob.java 35.58% <0%> (ø) 12 <0> (ø) ⬇️
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 64.12% <0%> (-0.21%) 64% <0%> (ø)
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java 79.28% <0%> (-0.2%) 4% <0%> (-1%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.58% <0%> (+0.12%) 264% <0%> (+1%) ⬆️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 56.26% <0%> (+0.13%) 0% <0%> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 33.11% <0%> (+0.19%) 260% <0%> (+1%) ⬆️
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 61.42% <0%> (+0.64%) 90% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9bebfa...f7400bf. Read the comment docs.

@cheenamalhotra cheenamalhotra added this to the 7.1.2 milestone Oct 27, 2018
@cheenamalhotra cheenamalhotra merged commit 7679dbe into microsoft:dev Oct 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants