Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix | Security Issue specified by sonarqube #928

Merged
merged 6 commits into from
Jan 11, 2019

Conversation

rene-ye
Copy link
Member

@rene-ye rene-ye commented Jan 9, 2019

Add a flag to XML transformer factory

@codecov-io
Copy link

codecov-io commented Jan 9, 2019

Codecov Report

Merging #928 into dev will decrease coverage by 0.1%.
The diff coverage is 56.89%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #928      +/-   ##
============================================
- Coverage     50.46%   50.35%   -0.11%     
+ Complexity     2932     2915      -17     
============================================
  Files           120      120              
  Lines         28117    28068      -49     
  Branches       4696     4693       -3     
============================================
- Hits          14190    14135      -55     
- Misses        11629    11633       +4     
- Partials       2298     2300       +2
Flag Coverage Δ Complexity Δ
#JDBC42 49.95% <56.89%> (+0.02%) 2877 <2> (-14) ⬇️
#JDBC43 50.27% <56.89%> (-0.15%) 2913 <2> (-17)
Impacted Files Coverage Δ Complexity Δ
...a/com/microsoft/sqlserver/jdbc/SQLServerNClob.java 100% <ø> (+25.92%) 7 <0> (-6) ⬇️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 55.51% <ø> (-0.25%) 0 <0> (ø)
.../com/microsoft/sqlserver/jdbc/SQLServerSQLXML.java 12.69% <0%> (-0.11%) 9 <0> (ø)
...qlserver/jdbc/osgi/SQLServerDataSourceFactory.java 35.84% <0%> (+0.66%) 7 <0> (ø) ⬇️
...va/com/microsoft/sqlserver/jdbc/SQLServerClob.java 34% <100%> (-1.59%) 4 <0> (-8)
...microsoft/sqlserver/jdbc/FailOverMapSingleton.java 13.79% <100%> (ø) 0 <0> (ø) ⬇️
...va/com/microsoft/sqlserver/jdbc/SQLServerBlob.java 35.05% <34.48%> (+0.17%) 18 <1> (ø) ⬇️
...a/com/microsoft/sqlserver/jdbc/PLPInputStream.java 58.57% <83.33%> (-0.95%) 33 <0> (-1)
...m/microsoft/sqlserver/jdbc/ActivityCorrelator.java 94.28% <87.5%> (+2.61%) 7 <1> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 40.65% <0%> (-4.4%) 13% <0%> (-2%)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57b504f...f3246bf. Read the comment docs.

cheenamalhotra
cheenamalhotra previously approved these changes Jan 9, 2019
@cheenamalhotra cheenamalhotra added this to the 7.2.0 milestone Jan 9, 2019
lilgreenbird
lilgreenbird previously approved these changes Jan 10, 2019
peterbae
peterbae previously approved these changes Jan 11, 2019
@cheenamalhotra cheenamalhotra merged commit f428514 into microsoft:dev Jan 11, 2019
@rene-ye rene-ye deleted the sonar-dev branch October 10, 2019 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants