-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build targets and props file for legacy csharp project support #127
Add build targets and props file for legacy csharp project support #127
Conversation
csharp/src/Microsoft.ML.OnnxRuntime/Microsoft.ML.OnnxRuntime.targets
Outdated
Show resolved
Hide resolved
csharp/src/Microsoft.ML.OnnxRuntime/Microsoft.ML.OnnxRuntime.targets
Outdated
Show resolved
Hide resolved
csharp/src/Microsoft.ML.OnnxRuntime/Microsoft.ML.OnnxRuntime.targets
Outdated
Show resolved
Hide resolved
<Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
|
||
<ItemGroup> | ||
<None Include="$(MSBuildThisFileDirectory)..\runtimes\win10-x64\native\onnxruntime.dll"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I've discussed this before but, why are we using the win10-x64
RID? Does the OnnxRuntime ONLY work on Windows 10 (and Windows Server 2016) machines?
Instead, I think the RID should be win-x64
, meaning it can run on other Windows machines (Windows 7, 8.1, Server 2012 etc)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pending on testing on other windows platforms. Currently onnxruntime.dll is tested on windows 10.
csharp/src/Microsoft.ML.OnnxRuntime/Microsoft.ML.OnnxRuntime.targets
Outdated
Show resolved
Hide resolved
csharp/src/Microsoft.ML.OnnxRuntime/Microsoft.ML.OnnxRuntime.csproj
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.