-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pdal] delete and replace different find modules #6603
Conversation
ah this requires probably the geotiff pr #6596 |
#6596 has been merged to |
Results: |
Seems like it did not get the memo that geotiff has been updated. Will merge the master later to this pr. The logs clearly shows that it is the proj.lib vs proj target error. |
/azp run |
Looks like this time is pdal-c instead of pdal that's failing on x86- and x64- Windows. I'm away from a PC, so I can't get the logs right now. |
Again... not to complain but I am sure you know that like the geotiff patch this is already present in #6000 since some time... |
I dont know that PR claims to fix LZMA and not geotiff and I am not actively watching all activtiy in vcpkg. I am just adding PRs to someday maybe get #5543 (or #6555) into vcpkg which will generally solve all link issues in regards to debug/release by injecting the correct vcpkg paths if necessary.
|
Regressions? The Preview CI does not show any. |
since i am only touching pdal and the only port dependent on pdal is pdal-c there seems to be an error in the CI build |
/azp run |
You're right, the CI results already looked suspicious once they only appeared on Mac OS. |
Thanks for the PR! |
makes linkage within pdal more robust.