[any-lite] Add new port (v0.2.0) #6629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
missing proper install |
Neumann-A
reviewed
May 26, 2019
ports/any-lite/portfile.cmake
Outdated
| SHA512 703900d7bac96d41f903b6cabba4bce15ef3cf7ef0a6a66de76230498ededff110e43d68d4a3fd6996869b2edd001f69bd53039a214d06b774ce99518f384a68 | ||
| ) | ||
|
|
||
| file(INSTALL ${SOURCE_PATH}/include/nonstd/any.hpp DESTINATION ${CURRENT_PACKAGES_DIR}/include/nonstd) |
There was a problem hiding this comment.
remove this line and do a proper install.
missing vcpkg_configure_cmake, vcpkg_install_cmake and vcpkg_fixup_cmake_targets
your CMakeLists.txt looks like it should be done this way!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also issue #1489