-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gdk-pixbuf] Fix Linux compilation. #6663
[gdk-pixbuf] Fix Linux compilation. #6663
Conversation
Hi @Kwizatz, thanks for your PR. Could you also bump the version in CONTROL file? |
@NancyLi1013 Done, I also bumped glib and libcroco's version since they also got small changes. |
172f2b7
to
76c7cdd
Compare
Unlike microsoft#6625 this version contains the minimal changes required to keep other dependencies as untouched as possible.
76c7cdd
to
318c2eb
Compare
... file from installation.
So, I don't see any issues when building gdk-pixbuf on Linux or Windows, so I think the problem may be some other library being affected as a side effect, but I don't know what that could be. |
It looks like qt5-imageformats:x64-windows is failing, although it is not obvious to me what the dependency is between that port and the ones you changed in this PR. |
Thanks! I'll take a look. |
I am unable to reproduce the failure locally so I am rerunning the tests. It is possible this is an unrelated failure due to other ports not behaving in the CI tests. If that is the case it should be investigated separately so it does not hold up this PR. We will see what the test results are when it finishes. |
Got the same results, qt5-imageformats:x64-windows built successfully locally. I'll await your results. |
The tests are now passing with the rerun. |
Unlike #6625 this version contains the minimal changes required
to keep other dependencies as untouched as possible.