Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LibRaw: include(SelectLibraryConfigurations) missing from findlibraw_debug_fix.patch #6715

Closed
mloskot opened this issue May 31, 2019 · 4 comments
Closed

LibRaw: include(SelectLibraryConfigurations) missing from findlibraw_debug_fix.patch #6715

mloskot opened this issue May 31, 2019 · 4 comments
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@mloskot
Copy link
Contributor

mloskot commented May 31, 2019 •
edited
Loading

Original FindLibRaw.cmake from LibRaw-cmake project does not contain the line include(SelectLibraryConfigurations), but the current patch calls the macro:

vcpkg/ports/libraw/findlibraw_debug_fix.patch

Lines 20 to 22 in b286cd5

+
+select_library_configurations(LibRaw)
+

The patch has been proposed to the upstram LibRaw/LibRaw-cmake#7

/cc @trylle
@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Jun 3, 2019
@trylle
Copy link
Contributor

trylle commented Jun 3, 2019

Hi, @mloskot. Am preparing a PR to fix this.

From a cursory check, it looks like some files in unrelated ports arrow/findzstd.patch and unicorn-lib/CMakeLists.txt are also missing this include, @JackBoosY.

@mloskot
Copy link
Contributor Author

mloskot commented Jun 3, 2019

@trylle I didn't check it all. I have got focused on preparing the patch for FindLibRaw.cmake to pushed it to the upstream. Once this succeeds, I was going to do the same with lcms2_debug_fix.patch. Then, move to reviewing the rest :)

trylle added a commit to trylle/vcpkg that referenced this issue Jun 6, 2019
@trylle
[libraw] Add include for select_library_configurations (microsoft#6715)
d66183d
@mloskot
Copy link
Contributor Author

mloskot commented Jun 6, 2019

PR ref #6742

@ras0219-msft
Copy link
Contributor

Should be fixed by #6742. Thanks!

ras0219-msft pushed a commit that referenced this issue Jun 10, 2019
@trylle @ras0219-msft
[libraw] Add include for select_library_configurations (#6715) (#6742)
06d5d39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mloskot @trylle @ras0219-msft @JackBoosY