-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[many ports] improvements for linux/wsl #6730
Conversation
[clapack] better integration with linux environment [visit-struct] put cmake config file in the expected folder [geogram] remove trailing underscore to enable compatibility with OpenBLAS
finally fixed the clapack very bad regression on linux introduced in #6542 |
…erwise internal ones thinks wrongly that openblas can also solve lapack libs
…empty default dependencies, unnecessary [core] tags
…dev/cenit/coin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we have the libusb changes as its own PR.
Could we also get all the changes associated with BLAS/LAPACK in its own PR.
I am still fixing things up, I will start thinking about splitting commits later, if ever. Just let me finish this work, then do whatever you want to merge what you need. |
I'd like to consider this work as done, in order to be ready for OpenCV 4... |
And I don't have the heart to pick the changes out into different prs. I'll audit the changes and merge once we get a green check. |
@cbezault ok, seems reasonable. |
@Rastaban maybe you know better what's going on here on windows. |
The Pacman error is a known issue that we're trying to fix permanently. It has to do with a lock file not getting deleted properly. Modifying A should retrigger a build of B unless you changed A back to a version that has already existed in the past. Anything else is a bug. |
you can just see the last two commits... just triggering rebuild of ports seems enough to fix them... I modified their dependencies to fix them (the bug was not in the ports themselves but in their dependencies), but it seems that they were not rebuilt and I had to do it manually. |
I'll look into it once I'm in today. It's concerning. |
Also don't bother retriggeing uwp. |
green mark? :) Please let me know any other review request you might have. Also because #5169 is ready, so I'd like to close this work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to slow this down.
No problem. Better to fix problems now before it’s too late. Just wanted to avoid wasted time, but review requests are never wasted time |
No description provided.