Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[itk] Upgrade to 5.0.0 #6767

Merged
merged 1 commit into from
Jun 14, 2019
Merged

Conversation

LilyWangL
Copy link
Contributor

Related to #6618

  1. Update to version 5.0.0
  2. Fix old patches and build error

@LilyWangL LilyWangL added the info:internal This PR or Issue was filed by the vcpkg team. label Jun 5, 2019
@vicroms vicroms merged commit d95b402 into microsoft:master Jun 14, 2019
@cenit
Copy link
Contributor

cenit commented Jun 15, 2019

I also had to deal with itk in my megaPR :D
I also updated to 5.0 and ended up requiring another patch. I am wondering how you could do without...?

@LilyWangL
Copy link
Contributor Author

Hi @cenit, can you provide your PR link? I didn't find it.

@cenit
Copy link
Contributor

cenit commented Jun 17, 2019

hi @wangli28 it's this one #6730
Today I will fix a couple of regression on osx due to flacky builds and then it will be ready for discussions/merging/whatever

@LilyWangL
Copy link
Contributor Author

@cenit Since this PR has been merged into master, can you merge my changes into your branch?
Thanks!

@cenit
Copy link
Contributor

cenit commented Jun 17, 2019

yes sure, I will merge master asap. Busy with other work atm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants