Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exiv2] update to 0.27.1 #6905

Merged
merged 1 commit into from
Jun 17, 2019
Merged

[Exiv2] update to 0.27.1 #6905

merged 1 commit into from
Jun 17, 2019

Conversation

jasjuang
Copy link
Contributor

Tested on windows and everything works like usual.

Note that there is a breaking change on cmake usage, instead of target_link_libraries(main PRIVATE xmp exiv2lib) now it becomes target_link_libraries(main PRIVATE exiv2-xmp exiv2lib)

@Rastaban Rastaban merged commit a861441 into microsoft:master Jun 17, 2019
@nartes
Copy link
Contributor

nartes commented Jul 2, 2019

@jasjuang, please test linux build. [1] it's not a complete package upgrade.

  1. iconv.patch doesn't apply
The following packages will be built and installed:
    exiv2[core]:x64-linux
Starting package 1/1: exiv2:x64-linux
Building package exiv2[core]:x64-linux...
-- Using cached /home/nartes/Documents/current/clothes-search/deps/vcpkg/downloads/Exiv2-exiv2-0.27.1.tar.gz
-- Extracting source /home/nartes/Documents/current/clothes-search/deps/vcpkg/downloads/Exiv2-exiv2-0.27.1.tar.gz
-- Applying patch iconv.patch
-- Applying patch failed. This is expected if this patch was previously applied.
-- Using source at /home/nartes/Documents/current/clothes-search/deps/vcpkg/buildtrees/exiv2/src/0.27.1-0acca1f921
-- Configuring x64-linux-dbg
^CError: Building package exiv2:x64-linux failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: exiv2:x64-linux
  Vcpkg version: 2019.06.21-unknownhash

Additionally, attach any relevant sections from the log files above.
  1. as a result Iconv::Iconv dependency breaks build, since it should be replaced

@jasjuang
Copy link
Contributor Author

jasjuang commented Jul 2, 2019

@nartes Unfortunately I don't have a vcpkg linux setup to test. If there's an error on linux I think the CI should catch it. Do you have any idea why it didn't?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants