Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libftdi] Fix header path propagation. #7015

Merged
merged 1 commit into from
Jun 27, 2019
Merged

[libftdi] Fix header path propagation. #7015

merged 1 commit into from
Jun 27, 2019

Conversation

seanyen
Copy link
Contributor

@seanyen seanyen commented Jun 24, 2019

$<INSTALL_INTERFACE:include> should go into the INTERFACE_INCLUDE_DIRECTORIES of the target.

@seanyen
Copy link
Contributor Author

seanyen commented Jun 24, 2019

@ras0219-msft I did some more edits to properly export INTERFACE_INCLUDE_DIRECTORIES from the target. Thanks!

@seanyen
Copy link
Contributor Author

seanyen commented Jun 27, 2019

@ras0219-msft @Rastaban I rebased my branch and resolved the conflicts.

@Rastaban Rastaban merged commit a6fe726 into microsoft:master Jun 27, 2019
@seanyen
Copy link
Contributor Author

seanyen commented Jun 27, 2019

Thanks for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seanyen @Rastaban