Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[armadillo] Fix build error in Linux #7022

Merged
merged 2 commits into from
Jun 25, 2019
Merged

[armadillo] Fix build error in Linux #7022

merged 2 commits into from
Jun 25, 2019

Conversation

LilyWangL
Copy link
Contributor

@LilyWangL LilyWangL commented Jun 25, 2019 •
edited
Loading

Building armadillo failed in Linux:

CMake Error at scripts/cmake/vcpkg_fixup_cmake_targets.cmake:53 (message):

  '/home/vwangli/Lily/vcpkg/packages/armadillo_x64-linux/debug/share/armadillo/CMake'
  does not exist.
Call Stack (most recent call first):
  ports/armadillo/portfile.cmake:28 (vcpkg_fixup_cmake_targets)
  scripts/ports.cmake:71 (include)

Because of case sensitivity in Linux, so I modified CONFIG_PATH armadillo/CMake to Armadillo/CMake in portfile.cmake.

Related issue: #6808

@LilyWangL LilyWangL added the info:internal This PR or Issue was filed by the vcpkg team. label Jun 25, 2019
@cenit
Copy link
Contributor

cenit commented Jun 25, 2019

Isn’t it easier to modify the vcpkg_fixup_cmake_target to share/Armadillo/CMake?

@LilyWangL LilyWangL marked this pull request as ready for review June 25, 2019 09:56
@LilyWangL
Copy link
Contributor Author

@cenit Thanks for your feedback!

@Rastaban Rastaban merged commit 6a6d350 into microsoft:master Jun 25, 2019
cenit
cenit reviewed Jun 25, 2019
View reviewed changes
ports/armadillo/portfile.cmake

vcpkg_copy_pdbs()

file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/include)
file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/share)
file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/share/Armadillo)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Windows/macOS (or any case-insensitive filesystem) it destroys the armadillo folder!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this line was not in the initial patch... strange that it passed CI

pull bot pushed a commit to harrysummer/vcpkg that referenced this pull request Jun 25, 2019
@LilyWangL @pull
[armadillo] Fix build error in Linux (microsoft#7022)
e551107 
 [armadillo] Fix installation path
@LilyWangL LilyWangL mentioned this pull request Jun 26, 2019
Merged
@arthur-tacca arthur-tacca mentioned this pull request Jul 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cenit cenit cenit left review comments

Assignees
No one assigned
Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LilyWangL @cenit @Rastaban