Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completion in inherit ctor doesn't include primary ctor params #3699

Closed
auduchinok opened this issue Oct 5, 2017 · 1 comment
Closed

Completion in inherit ctor doesn't include primary ctor params #3699

auduchinok opened this issue Oct 5, 2017 · 1 comment
Labels
Area-LangService-API Bug Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code.
Milestone
16.0

Comments

@auduchinok
Copy link
Member

auduchinok commented Oct 5, 2017 •
edited
Loading 

type A(param1, param2) =
    inherit B({caret}) // no param1/param2 completions here
@dsyme
Copy link
Contributor

dsyme commented Oct 5, 2017

I think there's already an issue on this. It seems likely it's a problem with the scope ranges coming from the type checker, but I'm not certain.

@dsyme dsyme added Bug Area-LangService-API Area-Compiler Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code. and removed Area-Compiler labels Oct 13, 2017
@cartermp cartermp added this to the 16.0 milestone Aug 29, 2018
auduchinok added a commit to auduchinok/fsharp that referenced this issue Dec 11, 2018
@auduchinok
Do not notify env sink about base constructor (fixes dotnet#3699)
d897e88
@auduchinok auduchinok mentioned this issue Dec 13, 2018
Merged
KevinRansom pushed a commit that referenced this issue Jan 31, 2019
@auduchinok @KevinRansom
Fix missing completion items in constructors of inherited types (#6002)
7523db9 
* Do not notify env sink about base constructor (fixes #3699)

* Extract function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-LangService-API Bug Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code.
Projects
None yet
Milestone
16.0
Development

No branches or pull requests
3 participants
@auduchinok @cartermp @dsyme