Fix Java Version Parsing #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Java Version Parsing did not work for OpenJDK 11. Updated to do exactly the parsing the redhat java extension does. Also updates package-lock.json, because my npm install did that and they should match
ThadHouse
force-pushed
the
fixjavaverparse
branch
from
b9b05ce
to
96a9295
Compare
|
The code is taken from https://github.com/Microsoft/vscode-java-debug/blob/7abda575111e9ce2221ad9420330e7764ccee729/src/launchCommand.ts which is MIT licensed so no license issue. The redhat version is very slightly different, but under the eclipse license, which might be an issue. |
|
Either this or #145 will fix JDK parsing. Which one the owners would prefer is up to them, I will close the not merged one. |
akaroml
approved these changes
Apr 28, 2019
|
Thank you for your contribution. @ThadHouse |
|
doesn't work with openjdk version "11.0.3" 2019-04-16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Java Version Parsing did not work for OpenJDK 11. Updated to do exactly the parsing the redhat java extension does.
Also updates package-lock.json, because my npm install did that and they should match.
Closes #143