Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server implementation should provide document validation queuing #42

Closed
dbaeumer opened this issue May 23, 2016 · 2 comments
Closed

Server implementation should provide document validation queuing #42

dbaeumer opened this issue May 23, 2016 · 2 comments
Labels
*out-of-scope Posted issue is not in scope of VS Code
Milestone

Comments

@dbaeumer
Copy link
Member

Currently linters are implemented by directly reacting in document changes (they validate when the change comes in). If n new requests come in while the document is active on 2 validation request should be executed. Currently most linters execute n + 1 validation request.

The implementation could make use of vs/base/common/async.ts#Throttler

@dbaeumer
Copy link
Member Author

Started to work on this. Still in beta.

@dbaeumer dbaeumer added this to the 4.0 milestone Apr 10, 2017
@dbaeumer
Copy link
Member Author

I made the whole json rpc message processing more async. I din't implement a queue to reuse since I couldn't come up with a good folding story. So I decided to leave this up for the server implementors (e.g eslint for example does implement a special queuing taking special eslint needs into consideration)

@dbaeumer dbaeumer added the *out-of-scope Posted issue is not in scope of VS Code label Nov 21, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

No branches or pull requests

1 participant