Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocomplete should not appear within comments #1123

Closed
DonJayamanne opened this issue Mar 20, 2018 · 3 comments · Fixed by #1129
Closed

Autocomplete should not appear within comments #1123

DonJayamanne opened this issue Mar 20, 2018 · 3 comments · Fixed by #1129
Assignees
@MikhailArkhipov
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. bug Issue identified by VS Code Team member as probable bug
Milestone
March 2018

Comments

@DonJayamanne
Copy link

DonJayamanne commented Mar 20, 2018 •
edited
Loading 

import sys
# sys.

Autocompletion will kick in after the period
@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. needs PR labels Mar 20, 2018
@DonJayamanne DonJayamanne added this to the March 2018 milestone Mar 20, 2018
@DonJayamanne
Copy link
Author

@MikhailArkhipov
If a text range starts from 7 to 9, then why isn't 9 considered to be within this text range.

See below test:
https://github.com/Microsoft/vscode-python/blob/master/src/test/language/textRange.test.ts#L43

@DonJayamanne DonJayamanne removed their assignment Mar 20, 2018
@MikhailArkhipov
Copy link

Specific to very end of a comment

@MikhailArkhipov MikhailArkhipov self-assigned this Mar 20, 2018
@DonJayamanne
Copy link
Author

DonJayamanne commented Mar 20, 2018 •
edited by brettcannon
Loading

Agreed, but this issue would occur majority of the time when typing in comments.

@MikhailArkhipov MikhailArkhipov mentioned this issue Mar 20, 2018
Merged
DonJayamanne added a commit that referenced this issue Mar 21, 2018
@DonJayamanne
Add news entry for #1096 and #1123
2b4a246 
Fixes #1135
@lock lock bot locked as resolved and limited conversation to collaborators Jul 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MikhailArkhipov MikhailArkhipov

Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
March 2018
Development

Successfully merging a pull request may close this issue.

Add missing operators in tokenizer, handle end-of-comment completion better
3 participants
@brettcannon @DonJayamanne @MikhailArkhipov