Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add localization support for strings in typescript code #463

Closed
DonJayamanne opened this issue Dec 20, 2017 · 5 comments
Closed

Add localization support for strings in typescript code #463

DonJayamanne opened this issue Dec 20, 2017 · 5 comments
Assignees
@DonJayamanne
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. feature-request Request for new features or functionality

Comments

@DonJayamanne
Copy link

Research the use of https://github.com/Microsoft/vscode-nls-dev
This adds support for localization of strings within Typescript and JS.
We should at least consider preparing for something similar to this, instead of hardcoding strings in TS and JS (as this only piles up the code that may need to be refactored).
@DonJayamanne DonJayamanne added awaiting 1-decision debt Covers everything internal: CI, testing, refactoring of the codebase, etc. feature-request Request for new features or functionality and removed awaiting 1-decision labels Dec 20, 2017
@DonJayamanne DonJayamanne self-assigned this Jun 3, 2018
@d3r3kk d3r3kk mentioned this issue Aug 2, 2018
Merged
5 tasks
@DonJayamanne

This comment has been minimized.

Sign in to view
@rchiodo
Copy link

rchiodo commented Oct 2, 2018

Changed to #2757

@rchiodo rchiodo mentioned this issue Oct 3, 2018
Merged
6 tasks
DonJayamanne pushed a commit that referenced this issue Oct 9, 2018
@rchiodo @DonJayamanne
Create localization of strings (#2757)
027832d 
Creation of a new module - localize. 
This doesn't use the vscode-nls and vscode-nls-dev as they
interfere with our code coverage.
Adding new strings requires adding them to the localize.ts and the
localize.nls.<locale>.json files.
Future work would be to translate the nls.json files into xlf files for
the loc team to own. We'd then write a build time task to turn the
xlf files into the output nls.<locale>.json files so that this code
works the same.

For #463
@DonJayamanne
Copy link
Author

Closing as this has been implemented.

@brettcannon
Copy link
Member

@DonJayamanne you said you were closing this but it's still open. Should it be closed?

@DonJayamanne DonJayamanne reopened this Dec 6, 2018
@DonJayamanne
Copy link
Author

The code has been implemented, however we need the loc team to provide the translations (localized package.nls.*.json files).

@lock lock bot locked as resolved and limited conversation to collaborators Jan 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. feature-request Request for new features or functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brettcannon @DonJayamanne @rchiodo