Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workbench Theming: Provide different colors for Notification buttons and badges #28280

Closed
akamud opened this issue Jun 9, 2017 · 1 comment
Closed
Assignees
Labels
feature-request Request for new features or functionality themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@akamud
Copy link
Contributor

akamud commented Jun 9, 2017

Right now the only custom colors available for the Notification bars are the background and foreground. This results in poor colors for themes using light background colors for the notification bar, but dark background colors for buttons and badges.

For example:
image

If I use a light foreground color for the Notification bar, the text is invisible.
If I use a dark foreground color, the buttons have poor contrast.

My suggestion is adding:

  • notification.buttonBackground
  • notification.buttonForeground
  • notification.errorBackground
  • notification.errorForeground
  • notification.warningBackground
  • notification.warningForeground
  • notification.infoBackground
  • notification.infoForeground
@bpasero bpasero added feature-request Request for new features or functionality themes Color theme issues workbench labels Jun 9, 2017
@bpasero bpasero removed their assignment Jun 9, 2017
@bpasero bpasero self-assigned this Jun 13, 2017
@bpasero bpasero added this to the June 2017 milestone Jun 13, 2017
@bpasero bpasero added the verification-needed Verification of issue is requested label Jun 13, 2017
@bpasero bpasero closed this as completed Jun 13, 2017
@isidorn isidorn added the verified Verification succeeded label Jun 28, 2017
@isidorn
Copy link
Contributor

isidorn commented Jun 28, 2017

screen shot 2017-06-28 at 16 59 41

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants