findFiles API should not get default excludes

[jrieken]

It seems that all API calls inhert the configured exclude settings which isn't what all extensions want.
Start reading here: #31882 (comment)

[jrieken]

fyi @joaomoreno

[bpasero]

I also think we should be careful about changing the defaults for performance reasons. @roblourens are we using ripgrep for the findFiles call or our old slow find mechanism?

[roblourens]

The old one, it takes the same path as quickopen.

[eamodio]

I just hit this case where findFiles is getting the default excludes (blocking me for searching for a file in the .git folder). I honestly don't mind that the default changed, but the fact that you can't override the default excludes by passing null or '' or something feels like a much bigger issue, imo.

[jrieken]

but the fact that you can't override the default excludes by passing null or '' or something feels like a much bigger issue, imo.

That.

[jrieken]

Moving this to December so that we can try this a little but my plan is to not-inherit default excludes when they are set to null via the API

[jrieken]

Refined API is allowing null for the exclude pattern exclude?: GlobPattern | null.

export function findFiles(include: GlobPattern, exclude?: GlobPattern | null, maxResults?: number, token?: CancellationToken): Thenable<Uri[]>;