Focus should not auto switch to launch.json when resolveDebugConfiguration api returns undefined

[testforstephen]

Currently, in ConfigurationProvider#resolveDebugConfiguration api, if it returns an empty value (e.g. undefined/null), VS Code will not continue the debug (i like this behavior), but in the meanwhile, it switches my focus to launch.json editor automatically. This is a little annoying.

In Java Debugger, we use ConfigurationProvider interface a lot. For example, force an incremental build before launching debug. If the build failed, and the user clicks Abort button, the debugger returns undefined to resolveDebugConfiguration api. See the screenshot below. It switches my focus to newly opened launch.json automatically. The expected behavior is only stopping the debug, not changing my focus.

[octref]

@isidorn How can I verify this? I tried making a failing preLaunchTask that runs tsc on an invalid ts file, but it's not the same thing.

@testforstephen It would be great if you could verify this is working for you in Insiders: https://code.visualstudio.com/insiders/

[testforstephen]

this issue still exists in the insider version 2018-08-30 .

[isidorn]

@testforstephen thanks for trying out, since the issue still exists, reopening and moving to september

[weinand]

duplicate of #54213

[weinand]

@testforstephen this should be fixed now in the next Insiders. See #54213.
If you return "undefined" nothing should happen with the editors. If you return "null" then the "launch.json" will be opened.

[testforstephen]

The insider version below works as expected. Thanks for fix.

1.28.0-insider (system setup)
Commit: 8330a695712c43f861ce5c47533d82637d3cb374
Date: 2018-09-13T11:25:00.283Z
Electron: 2.0.9
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
Architecture: x64