Add an AppData XML data file to Linux builds #17369

Merged
merged 1 commit into from Dec 19, 2016

Projects

None yet

3 participants

@aperezdc
Contributor

The AppData files provide descriptive data about an application, and is typically used in application managers to display additional information to the user. Having an AppData file is especially important for some graphical application installers: without one, an application manager may not event show an entry for the application. This happens for example in GNOME Software.

For the sake of completeness, this commit not only adds the AppData file to the Flatpak build, but also to the Linux .deb and .rpm packages.


This is follow-up to PR #16169 and a complement to issue #7112.

@msftclas

Hi @aperezdc, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@Tyriar Tyriar was assigned by bpasero Dec 16, 2016
resources/linux/code.appdata.xml
+<?xml version="1.0" encoding="UTF-8"?>
+<component type="desktop">
+ <id>@@NAME@@.desktop</id>
+ <metadata_license>CC-BY-SA-3.0</metadata_license>
@Tyriar
Tyriar Dec 16, 2016 Member

Let's leave this as MIT for now as I don't think we use a special license for metadata.

@aperezdc
aperezdc Dec 18, 2016 Contributor

Let's make this value come from product.licenseName as well, then.

resources/linux/code.appdata.xml
+<component type="desktop">
+ <id>@@NAME@@.desktop</id>
+ <metadata_license>CC-BY-SA-3.0</metadata_license>
+ <project_license>MIT</project_license>
@Tyriar
Tyriar Dec 16, 2016 Member

This can be sourced from product.licenseName now.

@aperezdc
aperezdc Dec 18, 2016 Contributor

Great, I'll rebase the branch and do precisely that.

@Tyriar Tyriar added this to the January 2017 milestone Dec 16, 2016
@aperezdc aperezdc Add an AppData XML data file to Linux builds
The AppData files provide descriptive data about an application, and is
typically used in application managers to display additional information to
the user. Having an AppData file is especially important for some graphical
application installers: without one, an application manager may not event
show an entry for the application. This happens for example in GNOME Software.

For the sake of completeness, this commit not only adds the AppData file to
the Flatpak build, but also to the Linux .deb and .rpm packages.
1e300d1
@aperezdc
Contributor

Updated!

@Tyriar
Member
Tyriar commented Dec 19, 2016

Thanks for the quick turn around @aperezdc, this is great ๐Ÿ˜„

@Tyriar
Tyriar approved these changes Dec 19, 2016 View changes
@Tyriar Tyriar merged commit 9769cd9 into Microsoft:master Dec 19, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@aperezdc
Contributor

@Tyriar: You're welcome! Also, it is being nice contributing to VS Code โ€” kudos for caring about keeping the community healthy ๐Ÿ˜„

@aperezdc aperezdc deleted the aperezdc:linux-appstream-xml branch Dec 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment