future3: Jukebox.Dockerfile - Reorder 'USER' command #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure the 'venv' is initalized using the correct user, preventing permission errors Closes issue MiczFlor#2198
votti
force-pushed
the
future3/fix/issue-#2198
branch
from
720a7c6
to
a7bc5e2
Compare
votti
changed the title
|
Looks good from my side. Ready to merge? |
pabera
approved these changes
Jan 2, 2024
|
Yeah. Was already discussed in #2167 |
AlvinSchiller
pushed a commit
to AlvinSchiller/RPi-Jukebox-RFID
that referenced
this pull request
Jan 9, 2024
This makes sure the 'venv' is initalized using the correct user, preventing permission errors Closes issue MiczFlor#2198 Co-authored-by: pre-commit fix Vito Zanotelli <vito.zanotelli@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure the 'venv' is created only after switching to the
$USER.This prevents permission errors if building the container in an environment where the user is not
pi.Closes issue #2198