Added "Resume playlist" functionality and removed unused play func #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Giving the rc interface a "play" command while paused will actually give you the feedback to enter "pause" again. Additionally, the code went for the wrong key. Since pause does pause/unpause, there is no need for "play"
Added -F to grep to allow special characters in files.
Changed grep to sed to make files with special characters work better.
Giving the rc interface a "play" command while paused will actually give you the feedback to enter "pause" again. Additionally, the code went for the wrong key. Since pause does pause/unpause, there is no need for "play"
|
pinging @princemaxwell for review as per micz request :) I found one inconsistency that someone else might be able to look at: The web interface directly starts vlc with commands. This will circumvent this functionality. It would be better to start the .sh trigger script with a parameter, but I'm not too sure how to do that, so maybe micz might now. |
|
I fixed the website but I'm not sure why it says it conflicts. I'm sure micz will resolve that :) I basically changed the call from directly invoking vlc to starting the trigger script with the id. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content Successor to #24 as I wanted to clean up the commit. See that PR for discussion.