-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(succeeded by #30 ) Added "resume playlist" functionality #24
Conversation
Giving the rc interface a "play" command while paused will actually give you the feedback to enter "pause" again. Additionally, the code went for the wrong key. Since pause does pause/unpause, there is no need for "play"
Hey, great idea. |
Added -F to grep to allow special characters in files.
Changed grep to sed to make files with special characters work better.
@princemaxwell Good catch, fixed that. |
@princemaxwell @Bockiii thanks guys. Lack of time requires me to delegate the authority for the decision to accept the pull requests to you :) the author and one peer reviewer. That should be good enough: can you both give me the thumbs up that this works? One question regarding the new script: scripts/track_playstate.sh It states: "Do this every 5 seconds. Can be tuned but will lower accuracy" If it goes into the documentation, it should go into this chapter, I think? |
Hi @MiczFlor , thats okay for me. It doesn't need to run in the cronjob as it's started by every card (and killed with every card). it's also only running during vlc is active (as to check if people kill vlc by web). This is my first time using github so I will do this: open new branch in my fork, commit all changes there and redo the PR as this one is kinda messy now. I will also add a note on how to use it in your documentation files (as a single trigger will restart last progress and double trigger will reset the playlist, that should be clarified). |
I was preparing a clean commit and found an issue: This will probably cause issues with .txt files that have urls in them. I will debug that in the coming days and do the pr. |
I posted a new PR for the clean commit. I tested this with .txt files and it worked. |
Major overhaul of the trigger file. Open for discussion :)