Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore missing playlist in webapp #623 #635

Merged
merged 1 commit into from
Nov 22, 2019

Conversation

ctietze
Copy link
Contributor

@ctietze ctietze commented Nov 20, 2019

  • Rework "currentsong" response processing, split key-value pairs at ": "
  • Change all response keys to lower case for further processing
  • Change "playlist" command to "playlistinfo" to receive additional track info (pos, time, albumLength)
  • Add singlequotes to directory shell arguments to support spaces in folders
  • Remove comma from playlist name if exists, to fix collapsable tracklist
  • Remove duplicate ":" from list argument
  • Hide overalltime for e.g. podcasts

Introduce php-unit as testing framework

  • Add composer as dependency manager
  • Add phpunit and php-mock as dependencies
  • Introduce namespace 'Jukebox' to enable mocking of build-in php functions e.g. "exec", "headers"

- Rework "currentsong" response processing, split key-value pairs at ": "
- Change all response keys to lower case for further processing
- Change "playlist" command to "playlistinfo" to receive additional track info (pos, time, albumLength)
- Add singlequotes to directory shell arguments to support spaces in folders
- Remove comma from playlist name if exists, to fix collapsable tracklist
- Remove duplicate ":" from list argument
- Hide overalltime for e.g. podcasts

Introduce php-unit as testing framework
- Add composer as dependency manager
- Add phpunit and php-mock as dependencies
- Introduce namespace 'Jukebox' to enable mocking of build-in php functions e.g. "exec", "headers"
@hinnerkoetting
Copy link
Contributor

I commented on the other PR before I saw this. Are there still issues open from my PR or did you fix everything?

@ctietze
Copy link
Contributor Author

ctietze commented Nov 20, 2019

Hi @hinnerkoetting,
as far as I checked the webapp with podcasts and mp3s it works as expected, but I would be happy if someone else could get a look and test it once more.

Last thing I'm currently struggling is the return value of the "./playlist_recursive_by_folder.php". The result of the m3uc file looks weird and I don't get mpd to play the Demo playlist file.
But there was no change in your PR so I guess that it wasn't working before, too.

Best regards
Clemens

@ctietze
Copy link
Contributor Author

ctietze commented Nov 20, 2019

Argh.. forget about the format of the m3cu. It looks good now there was a print_r debuggin line visible... :D

@MiczFlor
Copy link
Owner

Hi @ctietze @hinnerkoetting
quick question, before I merge to develop: will there be a difference between Phoniebox Classic and Phoniebox +Spotify? (I have no spotify :)
For example regarding the values returned in playlist.php from this line:

$statusCommand = "echo 'playlist\nclose' | nc -w 1 localhost 6600";

@MiczFlor MiczFlor merged commit 89a13bc into MiczFlor:develop Nov 22, 2019
@hinnerkoetting
Copy link
Contributor

I am not completely sure, I have spotify enabled. I guess it will depend on the content. That command also returns data when I play a webradio (without spotify).

@ctietze
Copy link
Contributor Author

ctietze commented Nov 28, 2019

Hi @MiczFlor,
I also don`t have a paid spotify account, but I found out, that you are also able to get a client ID and secret with a developer (free) account. Available under the following URL https://developer.spotify.com. I sadly lacked the time and hardware to set up the spotify version so far :/ But I will try it soon!
BR Clemens

@ctietze ctietze deleted the bugfix/playlist-not-displayed branch January 3, 2020 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants