Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch account lookups for sparse ledger creation #14527

Merged
merged 56 commits into from
Dec 5, 2023
Merged

Batch account lookups for sparse ledger creation #14527

merged 56 commits into from
Dec 5, 2023

Conversation

mrmr1993
Copy link
Member

@mrmr1993 mrmr1993 commented Nov 7, 2023

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@mrmr1993
Copy link
Member Author

mrmr1993 commented Nov 7, 2023

!ci-build-me

@mrmr1993
Copy link
Member Author

mrmr1993 commented Nov 7, 2023

!ci-nightly-me

@mrmr1993 mrmr1993 force-pushed the feature/batch-account-lookups branch from db2a399 to ae81c53 Compare November 7, 2023 13:23
@mergify mergify bot mentioned this pull request Nov 7, 2023
Merged
7 tasks
@mrmr1993
Copy link
Member Author

mrmr1993 commented Nov 8, 2023

!ci-build-me

@mrmr1993
Copy link
Member Author

mrmr1993 commented Nov 8, 2023

!ci-nightly-me

georgeee
georgeee reviewed Nov 8, 2023
View reviewed changes
src/lib/merkle_mask/masking_merkle_tree.ml Outdated
Either.first (location, Some account)
| None ->
Either.second location )
let locations_with_locations_rev, leftover_locations_rev =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest using the version

@mrmr1993 mrmr1993 marked this pull request as ready for review November 21, 2023 18:20
@mrmr1993 mrmr1993 requested a review from a team as a code owner November 21, 2023 18:20
@nholland94
Copy link
Member

!ci-build-me

@georgeee georgeee force-pushed the feature/batch-account-location-lookups branch from 187ec15 to c45bc86 Compare November 27, 2023 15:39
@georgeee georgeee force-pushed the feature/batch-account-lookups branch from eb3db50 to 2fbe1c5 Compare November 27, 2023 15:51
georgeee
georgeee approved these changes Nov 27, 2023
View reviewed changes
src/lib/mina_ledger/sparse_ledger.ml Outdated
let path, acct = Ledger.create_empty_exn ledger key in
(key :: new_keys, add_path sl path key acct) )
~init:([], of_ledger_root ledger)
let rec go (new_keys, sl) locations accounts =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be better structured, but will be amended in a PR up the PR chain

@georgeee georgeee force-pushed the feature/batch-account-location-lookups branch from 4123438 to b992841 Compare November 28, 2023 17:18
@georgeee georgeee force-pushed the feature/batch-account-lookups branch from 2fbe1c5 to daa60aa Compare November 28, 2023 17:21
@nholland94
Copy link
Member

!ci-build-me

@georgeee georgeee force-pushed the feature/batch-account-location-lookups branch from b992841 to f8c7017 Compare November 28, 2023 20:04
@georgeee georgeee force-pushed the feature/batch-account-lookups branch from daa60aa to 4271394 Compare November 28, 2023 20:06
Base automatically changed from feature/batch-account-location-lookups to rampup December 5, 2023 00:19
@deepthiskumar
Merge branch 'rampup' into feature/batch-account-lookups
ab04217
@deepthiskumar
Merge branch 'feature/batch-account-lookups' into feature/batch-merkl…
abad9ad 
…e-path-lookups
@deepthiskumar
Merge branch 'feature/batch-merkle-path-lookups' into feature/improve…
df8eba8 
…d-merkle-masks-for-staged-ledger
@deepthiskumar
Merge branch 'feature/improved-merkle-masks-for-staged-ledger' into f…
0416114 
…eature/merkle-mask-preloading
@deepthiskumar
Merge branch 'feature/merkle-mask-preloading' into feature/merkle-mas…
b2e07a7 
…k-empty-account-preloading
@deepthiskumar
Merge branch 'feature/merkle-mask-empty-account-preloading' into feat…
a27ed50 
…ure/sparse-ledger-of-subset-no-mutability
@deepthiskumar
Merge branch 'feature/sparse-ledger-of-subset-no-mutability' into fea…
5baa860 
…ture/sparse-ledger-wide-merkle-paths
@deepthiskumar
Merge branch 'feature/sparse-ledger-wide-merkle-paths' into feature/l…
7240af9 
…edger-mask-maps
@deepthiskumar
Copy link
Member

nightly pipeline passes https://buildkite.com/o-1-labs-2/mina-end-to-end-nightlies/builds/877#_

@deepthiskumar
Copy link
Member

!approved-for-mainnet

@deepthiskumar
Merge pull request #14528 from MinaProtocol/feature/batch-merkle-path…
1ba7954 
…-lookups

Batch merkle_path lookups in Sparse_ledger
@deepthiskumar
Merge pull request #14595 from MinaProtocol/feature/ledger-mask-maps
6458ec8 
Replace tables with maps in merkle masks
@deepthiskumar
Merge pull request #14594 from MinaProtocol/feature/sparse-ledger-wid…
5364a0f 
…e-merkle-paths

Use 'wide merkle paths' to optimize `Sparse_ledger.of_ledger_subset_exn`
@deepthiskumar
Merge pull request #14587 from MinaProtocol/feature/sparse-ledger-of-…
dc434fa 
…subset-no-mutability

Avoid ledger copy and mutation in `Sparse_ledger.of_ledger_subset_exn`
@deepthiskumar
Merge pull request #14585 from MinaProtocol/feature/merkle-mask-empty…
4b56a35 
…-account-preloading

Allow merkle masks to handle empty accounts directly
@deepthiskumar
Merge pull request #14571 from MinaProtocol/feature/merkle-mask-prelo…
d9035e7 
…ading

Preload accounts into merkle path for staged ledger diff application
@deepthiskumar
Merge pull request #14570 from MinaProtocol/feature/improved-merkle-m…
0b75a84 
…asks-for-staged-ledger

Performance improvement: fetch merkle paths from masks instead of disk
@deepthiskumar deepthiskumar merged commit 96dce55 into rampup Dec 5, 2023
2 checks passed
@deepthiskumar deepthiskumar deleted the feature/batch-account-lookups branch December 5, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgeee georgeee georgeee approved these changes

@nholland94 nholland94 nholland94 approved these changes

@ghost-not-in-the-shell ghost-not-in-the-shell ghost-not-in-the-shell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mrmr1993 @nholland94 @deepthiskumar @georgeee @ghost-not-in-the-shell