Preload accounts into merkle path for staged ledger diff application #14571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!ci-build-me |
|
!ci-nightly-me |
7 tasks
|
!ci-build-me |
georgeee
force-pushed
the
feature/improved-merkle-masks-for-staged-ledger
branch
2 times, most recently
from
0dca053
to
5085720
Compare
georgeee
force-pushed
the
feature/merkle-mask-preloading
branch
from
df57650
to
344a10d
Compare
ghost-not-in-the-shell
approved these changes
Nov 27, 2023
| @@ -613,6 +624,33 @@ module Make (Inputs : Inputs_intf.S) = struct | |||
| self_find_or_batch_lookup self_find_location | |||
| Base.location_of_account_batch | |||
|
|
|||
| let unsafe_preload_accounts_from_parent t account_ids = | |||
There was a problem hiding this comment.
@mrmr1993 A comment on when this could be used or should not be used would be helpful
ghost-not-in-the-shell
suggested changes
Nov 28, 2023
| let sibling_addr = Location.Addr.sibling addr in | ||
| let addr = Location.Addr.parent_exn addr in | ||
| let hash = match path with `Left hash | `Right hash -> hash in | ||
| self_set_hash t sibling_addr hash ; |
There was a problem hiding this comment.
I think we should use addr instead of sibling_addr here because merkle_path is already the path of siblings. We did it like this here because the merkle_path function itself is wrong.
There was a problem hiding this comment.
I cherry-picked all commits from PR #14586 (which I will close) to this branch and function set_merkle_path_unsafe stops being used and is completely removed by this change.
So I guess we can close this discussion.
georgeee
force-pushed
the
feature/improved-merkle-masks-for-staged-ledger
branch
2 times, most recently
from
6828275
to
5f56888
Compare
georgeee
force-pushed
the
feature/merkle-mask-preloading
branch
from
a0c92df
to
576bc95
Compare
Closed
7 tasks
ghost-not-in-the-shell
approved these changes
Nov 28, 2023
georgeee
force-pushed
the
feature/improved-merkle-masks-for-staged-ledger
branch
from
5f56888
to
d1e5ed8
Compare
georgeee
force-pushed
the
feature/merkle-mask-preloading
branch
from
576bc95
to
d530750
Compare
georgeee
force-pushed
the
feature/improved-merkle-masks-for-staged-ledger
branch
from
d1e5ed8
to
a636e02
Compare
georgeee
force-pushed
the
feature/merkle-mask-preloading
branch
from
d530750
to
b3525d3
Compare
georgeee
force-pushed
the
feature/merkle-mask-preloading
branch
from
b3525d3
to
5e71099
Compare
|
!ci-build-me |
Includes a bugfix in Merkle_ledger.Database.wide_merkle_path_batch
…eature/merkle-mask-preloading
…k-empty-account-preloading
…ure/sparse-ledger-of-subset-no-mutability
…ture/sparse-ledger-wide-merkle-paths
Replace tables with maps in merkle masks
…e-merkle-paths Use 'wide merkle paths' to optimize `Sparse_ledger.of_ledger_subset_exn`
…subset-no-mutability Avoid ledger copy and mutation in `Sparse_ledger.of_ledger_subset_exn`
…-account-preloading Allow merkle masks to handle empty accounts directly
deepthiskumar
merged commit d9035e7
into
feature/improved-merkle-masks-for-staged-ledger
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds preloading for ledger masks, using batch operations to get merkle paths and accounts for the transactions. This lets us avoid disk IO when applying transactions.
This PR builds upon #14570.
Checklist: