Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.15.1] Extend the config system and re-implement the config GUI #6421

Closed
wants to merge 17 commits into from
Closed

[1.15.1] Extend the config system and re-implement the config GUI #6421

wants to merge 17 commits into from

Conversation

Cadiboo
Copy link
Contributor

@Cadiboo Cadiboo commented Jan 10, 2020 •
edited
Loading

  • Adds the mods list button to the in game menu screen
  • Fixes some small bugs in the config system
  • Adds support for Bytes, Shorts and Floats
  • Re-implements the config GUI
  • Adds a test mod for the config system
  • Mostly re-implements FML's dummy config GUI
  • Extends the Javadocs on ModConfig.Type
  • Adds a Javadoc to FMLConfig telling modders to use Forge's system rather than NightConfig directly.

@tterrag1098
Copy link
Contributor

Some screenshots would be nice.

@tterrag1098 tterrag1098 added 1.15 Feature This request implements a new feature. labels Jan 10, 2020
@Cadiboo
Copy link
Contributor Author

Cadiboo commented Jan 10, 2020

Some screenshots would be nice.

Will do

@Cadiboo
Copy link
Contributor Author

Cadiboo commented Jan 10, 2020

2020-01-09_21 55 50
2020-01-09_21 56 02
2020-01-09_21 58 02
2020-01-09_21 59 40
2020-01-09_22 00 04
2020-01-10_13 31 34

@ichttt ichttt added the BreakingChange This request includes a change that would break compatibility with current versions of Forge. label Jan 10, 2020
@gigaherz gigaherz added the Work In Progress This request has lots of changes that need attention. label Jan 10, 2020
@gigaherz
Copy link
Contributor

gigaherz commented Jan 10, 2020 •
edited
Loading

[13:44] Cadiboo: Shit I just noticed some issues with my config’s handling of nested lists & configs
[13:44] Cadiboo: Is there a way to put a PR on hold or something?
[13:45] gigaherz: don't think so, but I can just mark it wip if you want
[13:45] Cadiboo: Yes pls ty

Marked as WIP until you tell us it's ready again.

@Unnoen
Copy link
Member

Unnoen commented Jan 10, 2020 •
edited
Loading

Just as a reminder, make sure to check for bugs/issues at different GUI scales and fullscreen.

@ichttt
Copy link
Member

ichttt commented Jan 10, 2020

It would be good if you could split this PR in two parts, one with all the breaking changes and one with the actual config gui implementation, so it is more easy to review, and we get the breaking changes merged before the first RB of 1.15.1.

@ichttt ichttt mentioned this pull request Jan 13, 2020
Merged
@Cadiboo
Copy link
Contributor Author

Cadiboo commented Jan 16, 2020

Just as a reminder, make sure to check for bugs/issues at different GUI scales and fullscreen.

The control buttons at the bottom have some issues when the width is small as they can't all fit on screen at the same time. Other than this there are no issues that I could find.

@Cadiboo
Copy link
Contributor Author

Cadiboo commented Jan 20, 2020 •
edited
Loading

The issues with my config gui’s handling of nested lists & configs have been fixed.
Should I now base this on top of ichttt's PR?
Also should I add the ability to sync the server configuration client -> server to allow OPs to change server configs remotely?

@Cadiboo
Make HoverChecker accept a generic Widget instead of a Button
6f8a719
@Cadiboo
Fix Forge config logging
4d27502
@Cadiboo
Add mods list button to ingame menu screen
891464e
@Cadiboo
Fix comments, capitalise "forge" where needed, reorganise config tran…
6797e4f 
…slations to reflect their order in the config
@Cadiboo
Update ForgeConfigSpec
8ab11eb 
Fix comments; Fix validator for Arrays.asList; Add support for Bytes, Short and Floats; Add support for limited value Bytes, Short, Floats and Longs; Improve support for limited value Enums; Make util fields and method public.
@Cadiboo
Create config test mod
b06652a
@Cadiboo
Add method to trim a string to size
d33778b
@Cadiboo
Make components accessible
cb6ee7e
@Cadiboo
Update MessageDialogScreen.java
ed7ba83
@Cadiboo
Config GUI + localisations
3d42dbc
@Cadiboo
Automatic config screen registration
42d1ceb
@Cadiboo
Re-implement the dummy config gui from FML
59cfcbd
@Cadiboo
Extend ModConfig.Type Javadocs and add examples
808ec2b
@Cadiboo
Add Javadoc to FMLConfig
35a995d
@pupnewfster pupnewfster mentioned this pull request Jan 20, 2020
Closed
@Cadiboo
Copy link
Contributor Author

Cadiboo commented Jan 22, 2020 •
edited
Loading

To make stuff easier to get into the RB and review separately everything is now split up.
This PR is superseded by #6437 for the breaking changes, #6464 for the config system improvements & bug fixes, #6466 for the fixes to Forge's config & translations and #6467 for the Config GUI.

@Cadiboo Cadiboo closed this Jan 22, 2020
@Cadiboo Cadiboo mentioned this pull request Jan 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.15 BreakingChange This request includes a change that would break compatibility with current versions of Forge. Feature This request implements a new feature. Work In Progress This request has lots of changes that need attention.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Cadiboo @tterrag1098 @gigaherz @Unnoen @ichttt