ref(event): change tick event to have pre/post classes

[danorris709]

Removes the phase variable in the TickEvent class and changes all the sub classes to have Pre/Post classes, as mentioned in here

Theoretically this would give a minor performance boost due to the singleton nature of the ClientTickEvent, however as that was not the primary goal of this I've not included any numbers and only mention this as an extra benefit

[PaintNinja]

Looks good to me - makes it harder for devs to accidentally have their things run twice per tick and improves consistency with other events.

Approving but leaving Lex to decide if he wants to merge now or next MC version.

[LexManos]

Throw some bin compat bouncers with @Deprecated(forRemoval = true, since = "1.20.4") and pull.
Few other notes, May be worth reformatting the event class to braces on same line like i've been doing while I go through.
Also super() calls are not needed as the no args call is implicit.

[danorris709]

Throw some bin compat bouncers with @Deprecated(forRemoval = true, since = "1.20.4") and pull. Few other notes, May be worth reformatting the event class to braces on same line like i've been doing while I go through. Also super() calls are not needed as the no args call is implicit.

For the deprecated tag do you mean that I should restore the variable and deprecate it?

[LexManos]

Yes doing so would allow it to be pulled in 1.20.4, however with 1.20.5 coming here soon it doesn't matter.

[danorris709]

Yes doing so would allow it to be pulled in 1.20.4, however with 1.20.5 coming here soon it doesn't matter.

Alright I've rebased it for latest versions & added back the phases with a deprecated annotation too

[LexManos]

All of these public -> protected are binary breaks.
Its fine to change them to protected {and move the phase to the end} but the public ones have to stay as bouncers.
And also you should mark the proper time for removal
@Deprecated(forRemoval = true, since = "1.20.6")

Maintaining binary compatibility means that your PR can be backported without major modifications

Suggested change

	protected ServerTickEvent(BooleanSupplier haveTime, MinecraftServer server, Phase phase) {
	@Deprecated(forRemoval = true, since = "1.20.6")
	public ServerTickEvent(Phase phase, BooleanSupplier haveTime, MinecraftServer server) {
	this(haveTime, server, phase);
	}
	protected ServerTickEvent(BooleanSupplier haveTime, MinecraftServer server, Phase phase) {

[danorris709]

Ah yes I completely missed that, thank you! I think I managed to get all of them now