Autoload sotrage adapters #555
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains Rack::MiniProfiler, not Rack::MiniProfiler::Profiler.
- Make module files require their nested contents - Move library requires to the files that use them - Remove require for timeout because it isn't used - Remove require for thread because it is required by default This patch also allows for easier transition to autoloading should we choose to use it later.
Autoloads storage adapters because it is unnecessary to load storage adapters you won't use. Autoload lets us defer loading the file until it is referenced, so that we can require storage dependencies normally and expect them to load when called.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #555 +/- ##
==========================================
+ Coverage 87.39% 87.42% +0.02%
==========================================
Files 18 20 +2
Lines 1269 1272 +3
==========================================
+ Hits 1109 1112 +3
Misses 160 160
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autoloads storage adapters because it is unnecessary to load storage
adapters you won't use. Autoload lets us defer loading the file until it
is referenced, so that we can require storage dependencies normally and
expect them to load when called.
Depends on #551. I can't make a PR to this repo if my merge target is on my fork, so this will have to do for now.