Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refs #67 Thumbor 7.0.0a5 #76

Closed
wants to merge 12 commits into from
Closed

refs #67 Thumbor 7.0.0a5 #76

wants to merge 12 commits into from

Conversation

gingerlime
Copy link
Contributor

@gingerlime gingerlime commented May 10, 2020

  • updated Dockerfile and docker-entrypoint based on
    Upgrade to thumbor 7.0.0 #67 (comment)
  • updated push, so we will push alpha tags on this branch, but not
    overwriting latest (and also semaphore CI)
  • using thumbor's built-in multiprocess

TODO

@gingerlime gingerlime changed the title Thumbor 7a5 refs #67 Thumbor 7a5 May 10, 2020
@gingerlime gingerlime mentioned this pull request May 10, 2020
4 tasks
@gingerlime gingerlime changed the title refs #67 Thumbor 7a5 refs #67 Thumbor 7.0.0a5 May 10, 2020
@gingerlime
Copy link
Contributor Author

pushed minimalcompact/thumbor:thumbor-7a5 tag to docker hub

@demosdemon
Copy link

demosdemon commented Jul 22, 2020

thanks for this, the 7.0.0 alpha image doesn't include the tc extras like tc_aws

edit: I just read your checklist, you already know this :P

@gingerlime
Copy link
Contributor Author

Thanks @demosdemon. Yes, it's on the list, but would appreciate any help during this process. So PRs or any other contribution is welcome.

@demosdemon
Copy link

Update:

I have a version of Thumbor 7 with unreleased versions of circus and tc_aws here. I hate git pinning, so this should not be used yet. I also tweaked the build script so I could easily build, tag, and upload under my namespace.

I also pulled Boost out into its own image. The Debian provided Boost uses different python header versions than the docker image (3.6 vs 3.8) which will eventually cause surprising and hard to diagnose issues. Doing this also allowed me to create a handy script to generate pinned requirements.txt using pip-tools. There was a reason why I pinned remotecv < 3, but I can't remember what it was now.

I also added some magic taken from the Docker python image to slim the apt dependencies after it's built. I've reduced the image size by 50%! This needs to be further tested to make sure any truly needed dependencies aren't falsely removed (I've already encountered a few).

I'll be cleaning this up over the weekend and will probably rebase/squash on top of your alpha branch. Let me know if you have any comments or questions?

@gingerlime
Copy link
Contributor Author

Thanks for the update @demosdemon ! Sounds like you did some serious digging into it 👍

A few notes from my side:

  • circus is no longer needed and was removed. Thumbor 7 supports multiprocess internally so there's no longer a need for it
  • reducing the size of the image sounds nice, but not a priority/objective for this project in my opinion. Thumbor is server software, and pretty stable overall. Pulling/pushing images can take a few seconds more or less, it doesn't make a huge difference. Stability/predictability is much more important. So I personally prefer to go with something safer that won't surprise us

Otherwise all sounds pretty great!

@gingerlime
Copy link
Contributor Author

I need some help figuring out the updates to requirements.txt ... Is this a safe option to use? I notice that it has a couple of non-stable pointers to git (e.g. tc_aws)...

How can we align/sync all the 3rd-party modules with thumbor 7 ?

Currently this PR only loads thumbor 7.0.0a5 without any other python modules, which obviously won't be that useful for users... Yet, I'm not sure which versions of 3rd party modules to use, hopefully still achieving backwards compatibility so if someone upgrades the docker image, (most) all dependencies are there...

@kkopachev @demosdemon @heynemann are you able to help here?

@heynemann
Copy link
Contributor

Working on it...

@gingerlime
Copy link
Contributor Author

let's continue on #103

@gingerlime gingerlime closed this Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants