-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refs #67 Thumbor 7.0.0a5 #76
Conversation
* updated Dockerfile and docker-entrypoint based on #67 (comment) * updated push, so we will push alpha tags on this branch, but not overwriting `latest` (and also semaphore CI)
This reverts commit 354a14f.
pushed |
thanks for this, the 7.0.0 alpha image doesn't include the edit: I just read your checklist, you already know this :P |
Thanks @demosdemon. Yes, it's on the list, but would appreciate any help during this process. So PRs or any other contribution is welcome. |
Update: I have a version of Thumbor 7 with unreleased versions of I also pulled Boost out into its own image. The Debian provided Boost uses different python header versions than the docker image (3.6 vs 3.8) which will eventually cause surprising and hard to diagnose issues. Doing this also allowed me to create a handy script to generate pinned requirements.txt using pip-tools. There was a reason why I pinned I also added some magic taken from the Docker python image to slim the apt dependencies after it's built. I've reduced the image size by 50%! This needs to be further tested to make sure any truly needed dependencies aren't falsely removed (I've already encountered a few). I'll be cleaning this up over the weekend and will probably rebase/squash on top of your alpha branch. Let me know if you have any comments or questions? |
Thanks for the update @demosdemon ! Sounds like you did some serious digging into it 👍 A few notes from my side:
Otherwise all sounds pretty great! |
I need some help figuring out the updates to How can we align/sync all the 3rd-party modules with thumbor 7 ? Currently this PR only loads thumbor 7.0.0a5 without any other python modules, which obviously won't be that useful for users... Yet, I'm not sure which versions of 3rd party modules to use, hopefully still achieving backwards compatibility so if someone upgrades the docker image, (most) all dependencies are there... @kkopachev @demosdemon @heynemann are you able to help here? |
Working on it... |
let's continue on #103 |
Upgrade to thumbor 7.0.0 #67 (comment)
overwriting
latest
(and also semaphore CI)TODO
requirements.txt
?