Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rpcs and syncvars now support generic components #574

Merged
merged 19 commits into from
Feb 21, 2021
Merged

feat: rpcs and syncvars now support generic components #574

merged 19 commits into from
Feb 21, 2021

Commits on Feb 10, 2021

  1. Fixed RPCs not working in generic classes

    @Hertzole
    Hertzole committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    2039d3c View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2021

  1. Added tests

    @Hertzole
    Hertzole committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    176ca02 View commit details
    Browse the repository at this point in the history

  2. Fixed ServerRpcs

    @Hertzole
    Hertzole committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    8c466df View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2021

  1. Fixed indentation

    @Hertzole
    Hertzole committed Feb 14, 2021
    Configuration menu
    Copy the full SHA
    ec26f4d View commit details
    Browse the repository at this point in the history

  2. Formatted Rpc tests

    @Hertzole
    Hertzole committed Feb 14, 2021
    Configuration menu
    Copy the full SHA
    d138270 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2021

  1. Almost fixed syncvars. 

    Added generic syncvar tests.
Also fixed generic fields straight up erroring out the weaver.
    @Hertzole
    Hertzole committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    681cb62 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2021

  1. Fixed badimageformat exception 

    It was calling the wrong property. Now it doesn't call the wrong property.
    @Hertzole
    Hertzole committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    5dffe7d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/MirageNet/Mirage into gen… 

    …eric_rpc

# Conflicts:
#	Assets/Mirage/Weaver/Processors/ClientRpcProcessor.cs
    @Hertzole
    Hertzole committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    fec445d View commit details
    Browse the repository at this point in the history

  3. Fixed RPCs again after migration

    @Hertzole
    Hertzole committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    3065e0a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' of https://github.com/MirageNet/Mirage into gen… 

    …eric_rpc
    @Hertzole
    Hertzole committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    2750526 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' of https://github.com/MirageNet/Mirage into gen… 

    …eric_rpc
    @Hertzole
    Hertzole committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    96d63f2 View commit details
    Browse the repository at this point in the history

  6. Fixed the rest of generics 

    Fixed network identities.
Fixed network behaviours.
    @Hertzole
    Hertzole committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    b5e4de4 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2021

  1. Resolved change requests and more tests. 

    Added tests for deeper sync vars.
Added tests for deeper RPCs.
    @Hertzole
    Hertzole committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    cfc9a6f View commit details
    Browse the repository at this point in the history

  2. Removed method duplication

    @Hertzole
    Hertzole committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    86a8205 View commit details
    Browse the repository at this point in the history

  3. Added comment.

    @Hertzole
    Hertzole committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    cb40e99 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2021

  1. use var when type is obvious

    @paulpach
    paulpach committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    577bf5c View commit details
    Browse the repository at this point in the history

  2. refator: simplify skeleton 

    We were adding the skeleton as a static method receiving a NetworkBehavior
then casting to the current class.

Instead this makes the skeleton not static with an implicit this parameter
already of the right type.
    @paulpach
    paulpach committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    96bcaae View commit details
    Browse the repository at this point in the history

  3. simplify skeleton

    @paulpach
    paulpach committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    b5dee85 View commit details
    Browse the repository at this point in the history

  4. use var when type is obvious

    @paulpach
    paulpach committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    9991d12 View commit details
    Browse the repository at this point in the history