feat: rpcs and syncvars now support generic components #574

Hertzole · 2021-02-10T22:03:32Z

This is quite a simple fix that makes RPCs work in generic classes.
I've created a helper method that will convert a type to a generic type if needed that is used in multiple places to keep the repeating code to a minimum.

paulpach · 2021-02-13T20:06:08Z

@Hertzole is it possible to write a unit test? It is really hard to figure out what problem you are trying to solve by looking at this code.

Hertzole · 2021-02-13T23:26:06Z

@paulpach I've added tests that are basically the same as the other RPC tests but with a generic class instead. I confirmed that they didn't work before the fixes and after the fixes.
I've also fixed ServerRpcs. I forgot about those but thankfully the tests reminded me.

paulpach

Looks good, just needs to fix indentation

Assets/Tests/Runtime/ClientServer/GenericNetworkBehaviourRpcTest.cs

Hertzole · 2021-02-14T14:31:07Z

I've fixed the indentation now. Stupid Visual Studio automatically "formatting" it.

paulpach · 2021-02-14T18:41:24Z

As discussed in discord, @Hertzole will add support for syncvars before we merge this.

Added generic syncvar tests. Also fixed generic fields straight up erroring out the weaver.

Hertzole · 2021-02-15T22:07:01Z

I've put some changes but it's still not complete. There are several issues. One I really need help with.
The main issue is that if you set a sync value in a base generic class, inside a coroutine, it will give you an exception. System.BadImageFormatException : Method with open type while not compiling gshared

This is only in classes that are generic, it seems. I've looked through the IL code and can not spot anything that wouldn't work.

Another issue that I will hopefully get the time to look at is that it doesn't yet serialize network identities. Just haven't gotten around to taking a look at that yet since I've been pretty busy with the exception above...

It was calling the wrong property. Now it doesn't call the wrong property.

…eric_rpc # Conflicts: # Assets/Mirage/Weaver/Processors/ClientRpcProcessor.cs

…eric_rpc

Fixed network identities. Fixed network behaviours.

Assets/Mirage/Weaver/Processors/PropertySiteProcessor.cs

paulpach

Looking good.

There is a weird edge case, and some things can be made clearer, but it is getting there.

Assets/Mirage/Weaver/TypeExtensions.cs

paulpach · 2021-02-19T09:05:43Z

Assets/Mirage/Weaver/Processors/SyncVarProcessor.cs

@@ -413,7 +413,15 @@ void WriteEndFunctionCall()
            {
                // only use Callvirt when not static
                OpCode opcode = hookMethod.IsStatic ? OpCodes.Call : OpCodes.Callvirt;
-                worker.Append(worker.Create(opcode, hookMethod));
+                MethodReference hookMethodReference = hookMethod;
+                // If the delcaring type is generic we need to duplicate the method reference.


as a rule of thumb, don't explain what this is doing. Explain why instead.

I can see that you are duplicating the method ref just by reading the code, the comment is redundant. What I can't figure out is why we are doing it.

I removed duplicate and changed it with some more straightforward code. I hope it becomes more clear.
Removed the duplicate in 86a8205 and added a comment in cb40e99.

Assets/Mirage/Weaver/TypeExtensions.cs

Added tests for deeper sync vars. Added tests for deeper RPCs.

We were adding the skeleton as a static method receiving a NetworkBehavior then casting to the current class. Instead this makes the skeleton not static with an implicit this parameter already of the right type.

# [67.4.0](v67.3.2...v67.4.0) (2021-02-21) ### Features * support generic network behaviors ([#574](#574)) ([715642c](715642c))

github-actions · 2021-02-21T21:30:16Z

🎉 This PR is included in version 67.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# [67.0.0](v66.2.1...v67.0.0) (2021-03-08) ### Bug Fixes * add comments and backing field for time ([MirageNet#618](https://github.com/James-Frowen/Mirage/issues/618)) ([da74e11](da74e11)) * add missing properties to interface ([MirageNet#617](https://github.com/James-Frowen/Mirage/issues/617)) ([e45920e](e45920e)) * disabling welcome window before unity 2020.1 ([MirageNet#662](https://github.com/James-Frowen/Mirage/issues/662)) ([a527af4](a527af4)) * invoking started event when Listening is false ([MirageNet#675](https://github.com/James-Frowen/Mirage/issues/675)) ([afef2d4](afef2d4)) * **weaver:** adding missing errors when Attributes are used in monobehaviour ([64b580b](64b580b)) * add summaries to event classes ([MirageNet#623](https://github.com/James-Frowen/Mirage/issues/623)) ([e6b9354](e6b9354)) * bug in tanks sample ([MirageNet#575](https://github.com/James-Frowen/Mirage/issues/575)) ([d82efea](d82efea)) * clientObjectManager was not using its interface ([MirageNet#615](https://github.com/James-Frowen/Mirage/issues/615)) ([d2b07ea](d2b07ea)) * drop support for older versions ([5dc12b5](5dc12b5)) * mirage icon missing in welcome window ([MirageNet#637](https://github.com/James-Frowen/Mirage/issues/637)) ([6c4dc9e](6c4dc9e)) * move interfaces into their own files ([MirageNet#613](https://github.com/James-Frowen/Mirage/issues/613)) ([432005b](432005b)) * multi scene example nre and event errors ([MirageNet#649](https://github.com/James-Frowen/Mirage/issues/649)) ([8c4c352](8c4c352)) * no longer true. spawnableobjects populated by FindObjectsOfTypeAll ([MirageNet#622](https://github.com/James-Frowen/Mirage/issues/622)) ([5692709](5692709)) * passing NetworkBehaviors in RPC works with IL2PP ([MirageNet#630](https://github.com/James-Frowen/Mirage/issues/630)) ([87becee](87becee)), closes [MirageNet#629](https://github.com/James-Frowen/Mirage/issues/629) * passing NetworkBehaviors in syncvars work with il2pp ([MirageNet#631](https://github.com/James-Frowen/Mirage/issues/631)) ([cd7317f](cd7317f)), closes [MirageNet#630](https://github.com/James-Frowen/Mirage/issues/630) [MirageNet#629](https://github.com/James-Frowen/Mirage/issues/629) * revert preprocessor change ([b89c454](b89c454)) * show selected tab when welcome screen is opened ([MirageNet#628](https://github.com/James-Frowen/Mirage/issues/628)) ([f6cae98](f6cae98)) * simplify checking if client is host ([MirageNet#602](https://github.com/James-Frowen/Mirage/issues/602)) ([dbf5784](dbf5784)) * static not needed ([MirageNet#604](https://github.com/James-Frowen/Mirage/issues/604)) ([879ba01](879ba01)) * stopping `: ` being at the start of all log messages ([MirageNet#606](https://github.com/James-Frowen/Mirage/issues/606)) ([8efe7ce](8efe7ce)) * welcome window icon not being found ([MirageNet#635](https://github.com/James-Frowen/Mirage/issues/635)) ([263a7b2](263a7b2)) * welcome window layout ([MirageNet#634](https://github.com/James-Frowen/Mirage/issues/634)) ([2bceedb](2bceedb)) ### Code Refactoring * **transports:** removing sendAsync from transports ([MirageNet#673](https://github.com/James-Frowen/Mirage/issues/673)) ([42b165f](42b165f)) * move LocalPlayer to ClientObjectManager ([MirageNet#619](https://github.com/James-Frowen/Mirage/issues/619)) ([df1e379](df1e379)) * remove unnecessary assembly definition ([MirageNet#599](https://github.com/James-Frowen/Mirage/issues/599)) ([89ffc7c](89ffc7c)) * removing sendasync from networkconnection ([MirageNet#672](https://github.com/James-Frowen/Mirage/issues/672)) ([e79b00e](e79b00e)) * removing un-used INetworkManager interface ([MirageNet#661](https://github.com/James-Frowen/Mirage/issues/661)) ([347bf6c](347bf6c)) * replacing version enum with assembly version ([MirageNet#663](https://github.com/James-Frowen/Mirage/issues/663)) ([d8facb7](d8facb7)) * spawnobjects throws exception instead of returning false ([MirageNet#639](https://github.com/James-Frowen/Mirage/issues/639)) ([4cb8afb](4cb8afb)) ### Features * add events to interfaces ([MirageNet#614](https://github.com/James-Frowen/Mirage/issues/614)) ([4d1a772](4d1a772)) * add more control over player spawning ([MirageNet#626](https://github.com/James-Frowen/Mirage/issues/626)) ([e0dd626](e0dd626)) * adding assert extension method to logger ([MirageNet#642](https://github.com/James-Frowen/Mirage/issues/642)) ([1df6081](1df6081)) * install/uninstall modules from welcome window ([MirageNet#593](https://github.com/James-Frowen/Mirage/issues/593)) ([53ac404](53ac404)) * support generic network behaviors ([MirageNet#574](https://github.com/James-Frowen/Mirage/issues/574)) ([715642c](715642c)) * welcome window shows active tab ([MirageNet#616](https://github.com/James-Frowen/Mirage/issues/616)) ([1411d0a](1411d0a)) ### Styles * renaming NetworkScenePath to ActiveScenePath ([MirageNet#647](https://github.com/James-Frowen/Mirage/issues/647)) ([7a26360](7a26360)) * renaming NumPlayers to NumberOfPlayers ([MirageNet#646](https://github.com/James-Frowen/Mirage/issues/646)) ([27b99be](27b99be)) ### BREAKING CHANGES * **transports:** Removed SendAsync from transport, use Send instead * Removed SendAsync from NetworkConnection. Use Send instead * Version.Current is no longer an enum and now returns Mirage's assembly version * removing INetworkManager * Use NetworkSceneManager.ActiveScenePath instead of NetworkSceneManager.NetworkScenePath * removing cref till docs are fixed * SpawnObjects throws Exception instead of returning false * Use NetworkServer.NumberOfPlayers instead of NetworkServer.NumPlayers * removed NetworkClient.LocalPlayer, use ClientObjectManager.LocalPlayer instead * removed MirageNG.asmdef, change your assembly to use Mirage.asmdef instead

# [67.0.0](v66.2.1...v67.0.0) (2021-04-21) ### Bug Fixes * add comments and backing field for time ([MirageNet#618](https://github.com/James-Frowen/Mirage/issues/618)) ([da74e11](da74e11)) * add missing properties to interface ([MirageNet#617](https://github.com/James-Frowen/Mirage/issues/617)) ([e45920e](e45920e)) * add summaries to event classes ([MirageNet#623](https://github.com/James-Frowen/Mirage/issues/623)) ([e6b9354](e6b9354)) * adding FormerlySerializedAs to networkanimator ([39f8fbd](39f8fbd)) * adding ISceneLoader to INetworkPlayer ([e8ab7a4](e8ab7a4)) * better name to stop namespace conflict with Unity ([MirageNet#755](https://github.com/James-Frowen/Mirage/issues/755)) ([69784e7](69784e7)) * bug in tanks sample ([MirageNet#575](https://github.com/James-Frowen/Mirage/issues/575)) ([d82efea](d82efea)) * changed icon to new mirage icons. ([MirageNet#758](https://github.com/James-Frowen/Mirage/issues/758)) ([04edac0](04edac0)) * clientObjectManager was not using its interface ([MirageNet#615](https://github.com/James-Frowen/Mirage/issues/615)) ([d2b07ea](d2b07ea)) * compilation issue on standalone build ([d6bea93](d6bea93)) * compression of 90 degrees angle ([MirageNet#689](https://github.com/James-Frowen/Mirage/issues/689)) ([2c0bac6](2c0bac6)) * correctly catch warning during weaver tests ([1d9df36](1d9df36)) * disabling welcome window before unity 2020.1 ([MirageNet#662](https://github.com/James-Frowen/Mirage/issues/662)) ([a527af4](a527af4)) * drop support for older versions ([5dc12b5](5dc12b5)) * fixing uses of message ([f2a5522](f2a5522)) * invoke client rpc only once in host mode ([MirageNet#744](https://github.com/James-Frowen/Mirage/issues/744)) ([ee6e55e](ee6e55e)) * invoking started event when Listening is false ([MirageNet#675](https://github.com/James-Frowen/Mirage/issues/675)) ([afef2d4](afef2d4)) * keep weaving references ([fab02df](fab02df)) * make sure resolved typedef isn't null ([MirageNet#731](https://github.com/James-Frowen/Mirage/issues/731)) ([2f6414f](2f6414f)) * mirage icon missing in welcome window ([MirageNet#637](https://github.com/James-Frowen/Mirage/issues/637)) ([6c4dc9e](6c4dc9e)) * move interfaces into their own files ([MirageNet#613](https://github.com/James-Frowen/Mirage/issues/613)) ([432005b](432005b)) * multi scene example nre and event errors ([MirageNet#649](https://github.com/James-Frowen/Mirage/issues/649)) ([8c4c352](8c4c352)) * no longer true. spawnableobjects populated by FindObjectsOfTypeAll ([MirageNet#622](https://github.com/James-Frowen/Mirage/issues/622)) ([5692709](5692709)) * only weave direct references ([fed5aea](fed5aea)) * passing NetworkBehaviors in RPC works with IL2PP ([MirageNet#630](https://github.com/James-Frowen/Mirage/issues/630)) ([87becee](87becee)), closes [MirageNet#629](https://github.com/James-Frowen/Mirage/issues/629) * passing NetworkBehaviors in syncvars work with il2pp ([MirageNet#631](https://github.com/James-Frowen/Mirage/issues/631)) ([cd7317f](cd7317f)), closes [MirageNet#630](https://github.com/James-Frowen/Mirage/issues/630) [MirageNet#629](https://github.com/James-Frowen/Mirage/issues/629) * removing redundant null checks ([909b668](909b668)) * revert preprocessor change ([b89c454](b89c454)) * show syncvar label ([c32a940](c32a940)) * weaver test assembler shouldn't log compiler errors anymore (2020.2+)) ([af1ceb4](af1ceb4)) * **weaver:** adding missing errors when Attributes are used in monobehaviour ([64b580b](64b580b)) * show selected tab when welcome screen is opened ([MirageNet#628](https://github.com/James-Frowen/Mirage/issues/628)) ([f6cae98](f6cae98)) * simplify checking if client is host ([MirageNet#602](https://github.com/James-Frowen/Mirage/issues/602)) ([dbf5784](dbf5784)) * static not needed ([MirageNet#604](https://github.com/James-Frowen/Mirage/issues/604)) ([879ba01](879ba01)) * stopping `: ` being at the start of all log messages ([MirageNet#606](https://github.com/James-Frowen/Mirage/issues/606)) ([8efe7ce](8efe7ce)) * welcome window icon not being found ([MirageNet#635](https://github.com/James-Frowen/Mirage/issues/635)) ([263a7b2](263a7b2)) * welcome window layout ([MirageNet#634](https://github.com/James-Frowen/Mirage/issues/634)) ([2bceedb](2bceedb)) ### Code Refactoring * changing indexer to try get ([MirageNet#720](https://github.com/James-Frowen/Mirage/issues/720)) ([01ca9bb](01ca9bb)) * move collections to Mirage.Collections ([MirageNet#698](https://github.com/James-Frowen/Mirage/issues/698)) ([e22f765](e22f765)) * move LocalPlayer to ClientObjectManager ([MirageNet#619](https://github.com/James-Frowen/Mirage/issues/619)) ([df1e379](df1e379)) * move logging into a folder and namespace ([MirageNet#697](https://github.com/James-Frowen/Mirage/issues/697)) ([814653f](814653f)) * move serialization into Mirage.Serialization ([MirageNet#700](https://github.com/James-Frowen/Mirage/issues/700)) ([5dc037d](5dc037d)) * moving static send to NetworkServer ([MirageNet#692](https://github.com/James-Frowen/Mirage/issues/692)) ([5b19dc3](5b19dc3)) * moving syncvar sending to its own class ([9699e03](9699e03)) * remove local visibility hacks ([MirageNet#696](https://github.com/James-Frowen/Mirage/issues/696)) ([df499ab](df499ab)) * remove unnecessary assembly definition ([MirageNet#599](https://github.com/James-Frowen/Mirage/issues/599)) ([89ffc7c](89ffc7c)) * removing address property from player ([MirageNet#691](https://github.com/James-Frowen/Mirage/issues/691)) ([d772e53](d772e53)) * removing connection to server ([MirageNet#703](https://github.com/James-Frowen/Mirage/issues/703)) ([ff95634](ff95634)) * removing disconnect method from player ([MirageNet#688](https://github.com/James-Frowen/Mirage/issues/688)) ([e1daf92](e1daf92)) * removing sendasync from networkconnection ([MirageNet#672](https://github.com/James-Frowen/Mirage/issues/672)) ([e79b00e](e79b00e)) * removing un-used INetworkManager interface ([MirageNet#661](https://github.com/James-Frowen/Mirage/issues/661)) ([347bf6c](347bf6c)) * rename connection to player ([MirageNet#706](https://github.com/James-Frowen/Mirage/issues/706)) ([03e8cfa](03e8cfa)) * rename PlayerSpawner to CharacterSpawner ([MirageNet#686](https://github.com/James-Frowen/Mirage/issues/686)) ([1db3498](1db3498)) * renaming NetworkConnection to NetworkPlayer ([MirageNet#684](https://github.com/James-Frowen/Mirage/issues/684)) ([3ecb659](3ecb659)) * replacing version enum with assembly version ([MirageNet#663](https://github.com/James-Frowen/Mirage/issues/663)) ([d8facb7](d8facb7)) * spawnobjects throws exception instead of returning false ([MirageNet#639](https://github.com/James-Frowen/Mirage/issues/639)) ([4cb8afb](4cb8afb)) * using interface instead of network client ([MirageNet#721](https://github.com/James-Frowen/Mirage/issues/721)) ([703596a](703596a)) * using interface instead of network server ([MirageNet#722](https://github.com/James-Frowen/Mirage/issues/722)) ([7312bd8](7312bd8)) * **transports:** removing sendAsync from transports ([MirageNet#673](https://github.com/James-Frowen/Mirage/issues/673)) ([42b165f](42b165f)) ### Features * 0 is not lossy when compressing quaternions ([MirageNet#695](https://github.com/James-Frowen/Mirage/issues/695)) ([c1552c0](c1552c0)) * add events to interfaces ([MirageNet#614](https://github.com/James-Frowen/Mirage/issues/614)) ([4d1a772](4d1a772)) * add more control over player spawning ([MirageNet#626](https://github.com/James-Frowen/Mirage/issues/626)) ([e0dd626](e0dd626)) * adding assert extension method to logger ([MirageNet#642](https://github.com/James-Frowen/Mirage/issues/642)) ([1df6081](1df6081)) * adding class that will invoke late handlers ([631adce](631adce)) * adding Connection property to NetworkPlayer ([MirageNet#687](https://github.com/James-Frowen/Mirage/issues/687)) ([5e1c4ba](5e1c4ba)) * adding logger.Assert that doesn't require a message ([8c213e3](8c213e3)) * configurable wait time for tests ([MirageNet#729](https://github.com/James-Frowen/Mirage/issues/729)) ([b10f3e8](b10f3e8)) * install/uninstall modules from welcome window ([MirageNet#593](https://github.com/James-Frowen/Mirage/issues/593)) ([53ac404](53ac404)) * not listening can now be toggled at runtime. fixes host spawning ([MirageNet#728](https://github.com/James-Frowen/Mirage/issues/728)) ([256b16c](256b16c)) * sample for interest management ([MirageNet#727](https://github.com/James-Frowen/Mirage/issues/727)) ([0f4cdc5](0f4cdc5)) * support generic network behaviors ([MirageNet#574](https://github.com/James-Frowen/Mirage/issues/574)) ([715642c](715642c)) * welcome window shows active tab ([MirageNet#616](https://github.com/James-Frowen/Mirage/issues/616)) ([1411d0a](1411d0a)) ### Performance Improvements * clientrpc in host mode bypasses network ([MirageNet#714](https://github.com/James-Frowen/Mirage/issues/714)) ([edb0705](edb0705)) * serverrpc bypasses network on host mode ([MirageNet#708](https://github.com/James-Frowen/Mirage/issues/708)) ([695eb46](695eb46)) ### Styles * renaming NetworkScenePath to ActiveScenePath ([MirageNet#647](https://github.com/James-Frowen/Mirage/issues/647)) ([7a26360](7a26360)) * renaming NumPlayers to NumberOfPlayers ([MirageNet#646](https://github.com/James-Frowen/Mirage/issues/646)) ([27b99be](27b99be)) ### BREAKING CHANGES * networkManager.SceneManager removed to networkManager.NetworkSceneManager * Dirty object collection is now inside SyncVarSender * fields and parameters using NetworkServer are now using INetworkServer Instead * fields and parameters using NetworkClient are now using INetworkClient Instead * ObjectLocator now has TryGet method instead of indexer that returns null * updating uses of objectLocator * fixing names not being the same * Removed ConnectionToServer property * removing uses of ConnectionToServer * removing use in test * removing ClientRpc player target * creating null * changing tests to expect null * fixing docs * using client player for target rpc Co-authored-by: Paul Pacheco <paulpach@gmail.com> * fixing tests for rpc target Co-authored-by: Paul Pacheco <paulpach@gmail.com> * ServerRpc execute synchronous in host mode * Connection renamed to player * NetworkReader and NetworkWriter moved to Mirage.Serialization namespace * collections moved to Mirage.Collections * Logging moved into a namespace, use Mirror.Logging * NetworkVisibility no longer disables renderers in host mode * moving NetworkPlayer.Send to NetworkServer.SendToMany * Address replaced with Connection.GetEndPointAddress * updating uses of Address * Disconnect replaced with Connection.Disconnect * fixing uses in Mirage * updating uses in authenticators * Renamed PlayerSpawner to CharacterSpawner * renaming NetworkConnection to NetworkPlayer * renaming types in weaver tests * fixing test message * fixing xref in docs * **transports:** Removed SendAsync from transport, use Send instead * Removed SendAsync from NetworkConnection. Use Send instead * Version.Current is no longer an enum and now returns Mirage's assembly version * removing INetworkManager * Use NetworkSceneManager.ActiveScenePath instead of NetworkSceneManager.NetworkScenePath * removing cref till docs are fixed * SpawnObjects throws Exception instead of returning false * Use NetworkServer.NumberOfPlayers instead of NetworkServer.NumPlayers * removed NetworkClient.LocalPlayer, use ClientObjectManager.LocalPlayer instead * removed MirageNG.asmdef, change your assembly to use Mirage.asmdef instead

Fixed RPCs not working in generic classes

2039d3c

Hertzole changed the title ~~Fix RPCs not working in generic classes~~ fix: RPCs not working in generic classes Feb 10, 2021

Lymdun changed the title ~~fix: RPCs not working in generic classes~~ fix: rpcs not working in generic classes Feb 11, 2021

Hertzole added 2 commits February 14, 2021 00:15

Added tests

176ca02

Fixed ServerRpcs

8c466df

paulpach requested changes Feb 14, 2021

View reviewed changes

Assets/Tests/Runtime/ClientServer/GenericNetworkBehaviourRpcTest.cs Outdated Show resolved Hide resolved

paulpach changed the title ~~fix: rpcs not working in generic classes~~ feat: rpcs now support generic components Feb 14, 2021

Fixed indentation

ec26f4d

Formatted Rpc tests

d138270

uweeby added the Work In Progess Shouldn't be merged yet label Feb 15, 2021

erikas-taroza marked this pull request as draft February 15, 2021 21:59

Almost fixed syncvars.

681cb62

Added generic syncvar tests. Also fixed generic fields straight up erroring out the weaver.

Hertzole added 6 commits February 17, 2021 20:08

Fixed badimageformat exception

5dffe7d

It was calling the wrong property. Now it doesn't call the wrong property.

Merge branch 'master' of https://github.com/MirageNet/Mirage into gen…

fec445d

…eric_rpc # Conflicts: # Assets/Mirage/Weaver/Processors/ClientRpcProcessor.cs

Fixed RPCs again after migration

3065e0a

Merge branch 'master' of https://github.com/MirageNet/Mirage into gen…

2750526

…eric_rpc

Merge branch 'master' of https://github.com/MirageNet/Mirage into gen…

96d63f2

…eric_rpc

Fixed the rest of generics

b5e4de4

Fixed network identities. Fixed network behaviours.

Hertzole marked this pull request as ready for review February 17, 2021 22:53

Hertzole changed the title ~~feat: rpcs now support generic components~~ feat: rpcs and syncvars now support generic components Feb 17, 2021

paulpach reviewed Feb 19, 2021

View reviewed changes

Assets/Mirage/Weaver/Processors/PropertySiteProcessor.cs Outdated Show resolved Hide resolved

paulpach requested changes Feb 19, 2021

View reviewed changes

Hertzole added 3 commits February 19, 2021 21:07

Resolved change requests and more tests.

cfc9a6f

Added tests for deeper sync vars. Added tests for deeper RPCs.

Removed method duplication

86a8205

Added comment.

cb40e99

Hertzole requested a review from paulpach February 19, 2021 20:25

paulpach added 4 commits February 21, 2021 12:56

use var when type is obvious

577bf5c

refator: simplify skeleton

96bcaae

We were adding the skeleton as a static method receiving a NetworkBehavior then casting to the current class. Instead this makes the skeleton not static with an implicit this parameter already of the right type.

simplify skeleton

b5dee85

use var when type is obvious

9991d12

paulpach approved these changes Feb 21, 2021

View reviewed changes

paulpach merged commit 715642c into MirageNet:master Feb 21, 2021

github-actions bot pushed a commit that referenced this pull request Feb 21, 2021

chore(release): 67.4.0 [skip ci]

4b1560e

# [67.4.0](v67.3.2...v67.4.0) (2021-02-21) ### Features * support generic network behaviors ([#574](#574)) ([715642c](715642c))

github-actions bot added the released label Feb 21, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: rpcs and syncvars now support generic components #574

feat: rpcs and syncvars now support generic components #574

Hertzole commented Feb 10, 2021

paulpach commented Feb 13, 2021

Hertzole commented Feb 13, 2021

paulpach left a comment

Hertzole commented Feb 14, 2021

paulpach commented Feb 14, 2021

Hertzole commented Feb 15, 2021

paulpach left a comment

paulpach Feb 19, 2021

Hertzole Feb 19, 2021

github-actions bot commented Feb 21, 2021

feat: rpcs and syncvars now support generic components #574

feat: rpcs and syncvars now support generic components #574

Conversation

Hertzole commented Feb 10, 2021

paulpach commented Feb 13, 2021

Hertzole commented Feb 13, 2021

paulpach left a comment

Choose a reason for hiding this comment

Hertzole commented Feb 14, 2021

paulpach commented Feb 14, 2021

Hertzole commented Feb 15, 2021

paulpach left a comment

Choose a reason for hiding this comment

paulpach Feb 19, 2021

Choose a reason for hiding this comment

Hertzole Feb 19, 2021

Choose a reason for hiding this comment

github-actions bot commented Feb 21, 2021