Merge "Added per disk PUT timing monitoring support."

Mirantis · Mar 6, 2013 · 28ac46d · 28ac46d
2 parents 7fd4323 + 1d8a02f
commit 28ac46d
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 0 deletions.
diff --git a/doc/source/admin_guide.rst b/doc/source/admin_guide.rst
@@ -756,6 +756,9 @@ Metric Name                              Description
 `object-server.PUT.timeouts`             Count of object PUTs which exceeded max_upload_time.
 `object-server.PUT.timing`               Timing data for each PUT request not resulting in an
                                          error.
+`object-server.PUT.<device>.timing`      Timing data per kB transfered (ms/kB) for each 
+                                         non-zero-byte PUT request on each device. 
+                                         Monitoring problematic devices, higher is bad. 
 `object-server.GET.errors.timing`        Timing data for GET request errors: bad request,
                                          not mounted, header timestamps before the epoch,
                                          precondition failed.

diff --git a/swift/common/utils.py b/swift/common/utils.py
@@ -492,6 +492,12 @@ def timing_since(self, metric, orig_time, sample_rate=None):
         return self.timing(metric, (time.time() - orig_time) * 1000,
                            sample_rate)
 
+    def transfer_rate(self, metric, elasped_time, byte_xfer, sample_rate=None):
+        if byte_xfer:
+            return self.timing(metric,
+                               elasped_time * 1000 / byte_xfer * 1000,
+                               sample_rate)
+
 
 def timing_stats(**dec_kwargs):
     """
@@ -646,6 +652,7 @@ def wrapped(self, *a, **kw):
     decrement = statsd_delegate('decrement')
     timing = statsd_delegate('timing')
     timing_since = statsd_delegate('timing_since')
+    transfer_rate = statsd_delegate('transfer_rate')
 
 
 class SwiftLogFormatter(logging.Formatter):

diff --git a/swift/obj/server.py b/swift/obj/server.py
@@ -643,13 +643,15 @@ def PUT(self, request):
         etag = md5()
         upload_size = 0
         last_sync = 0
+        elasped_time = 0
         with file.mkstemp() as fd:
             try:
                 fallocate(fd, int(request.headers.get('content-length', 0)))
             except OSError:
                 return HTTPInsufficientStorage(drive=device, request=request)
             reader = request.environ['wsgi.input'].read
             for chunk in iter(lambda: reader(self.network_chunk_size), ''):
+                start_time = time.time()
                 upload_size += len(chunk)
                 if time.time() > upload_expiration:
                     self.logger.increment('PUT.timeouts')
@@ -664,6 +666,11 @@ def PUT(self, request):
                     drop_buffer_cache(fd, last_sync, upload_size - last_sync)
                     last_sync = upload_size
                 sleep()
+                elasped_time += time.time() - start_time
+
+            if upload_size:
+                self.logger.transfer_rate(
+                    'PUT.' + device + '.timing', elasped_time, upload_size)
 
             if 'content-length' in request.headers and \
                     int(request.headers['content-length']) != upload_size: