You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
When NetworkServer.SendToAll is called it does not check the size before calling conn.Send(ArraySegment...). This can cause large message to be added to batches which will then result in unhelpful errors:
[IMPORTANT] How can we reproduce the issue, step by step:
call NetworkServer.SendToAll<MyMessage>(...) with a message that is bigger than transport can send
Expected behavior
SendToAll should check size (by calling ValidatePacketSize ?). and log error with the stack that will tell user what message is too big, for example:
Describe the bug
When NetworkServer.SendToAll is called it does not check the size before calling
conn.Send(ArraySegment...)
. This can cause large message to be added to batches which will then result in unhelpful errors:[IMPORTANT] How can we reproduce the issue, step by step:
NetworkServer.SendToAll<MyMessage>(...)
with a message that is bigger than transport can sendExpected behavior
SendToAll should check size (by calling
ValidatePacketSize
?). and log error with the stack that will tell user what message is too big, for example:This will then allow user to track down what is sending it
Desktop (please complete the following information):
Looks like it would be a problem in v86.14.0, but I havn't tested that
Additional context
source:
Mirror/Assets/Mirror/Core/NetworkServer.cs
Lines 478 to 497 in 325cc15
The text was updated successfully, but these errors were encountered: