Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOS implementation in NL backend #187

Open
Ajay-Maury opened this issue Apr 4, 2024 · 5 comments · Fixed by #191
Open

SOS implementation in NL backend #187

Ajay-Maury opened this issue Apr 4, 2024 · 5 comments · Fixed by #191
Assignees

Comments

@Ajay-Maury
Copy link
Collaborator

Ajay-Maury commented Apr 4, 2024

Sub-ticket of:- https://github.com/Mission-Prerna/prerna-lakshya-app/issues/424

In NL backend creating a new table for SOS reports as school_results_fraud_reports which will include

  • id for unique and will be auto incremented
  • udise of school
  • cycle_id in which school result marked as SOS
  • mentor_id of mentor who marked SOS
  • is_fraud as a boolean value
  • created_at timestamp of creation
  • updated_at timestamp

It can be created multiple times for a school by the same mentor and in the same cycle, so no unique combination of these will be there.

Any examiner mark the listed school as SOS wether he had assessed that particular school or not.

@Ajay-Maury Ajay-Maury self-assigned this Apr 4, 2024
@Ajay-Maury Ajay-Maury linked a pull request Apr 4, 2024 that will close this issue
@Ajay-Maury Ajay-Maury linked a pull request Apr 5, 2024 that will close this issue
@tushar5526
Copy link
Contributor

tushar5526 commented Apr 8, 2024

@Ajay-Maury is working on adding stricter checks. @Ajay-Maury to add a list of checks that will be added.

@karntrehan
Copy link
Contributor

is_fraud will always be true right? Should we have it then?

@Ajay-Maury
Copy link
Collaborator Author

Ajay-Maury commented Apr 9, 2024

@Ajay-Maury is working on adding stricter checks. @Ajay-Maury to add a list of checks that will be added.

The following points need to be checked before creating an entry in DB:-

  • Cycle exists or not
  • Cycle started or not
  • Cycled closed
  • The given school is assessed or not (If needed can be checked for that the particular examiner is assessed that school or anyone else)
  • User is examiner or not

Need to confirm:-

  • Can examiner make fraud after closing the assessment cycle
  • Can any other examiner mark the school result as fraud or only that examiner who accessed (can be checked on BE)
  • Can a school that is not nipun in result be marked as SOS

@Ajay-Maury
Copy link
Collaborator Author

is_fraud will always be true right? Should we have it then?

Changed to is_valid for soft deletion

@rohitsamagra
Copy link

  • Completed and merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants