Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aligned Logo new #31

Merged
merged 6 commits into from
Aug 7, 2019
Merged

Aligned Logo new #31

merged 6 commits into from
Aug 7, 2019

Conversation

Mr-Pine
Copy link
Collaborator

@Mr-Pine Mr-Pine commented Aug 7, 2019

No description provided.

@Mr-Pine Mr-Pine added the enhancement New feature or request label Aug 7, 2019
@Mr-Pine Mr-Pine self-assigned this Aug 7, 2019
@Mr-Pine Mr-Pine added this to To Do in Karambolage via automation Aug 7, 2019
@Mister-Muffin

This comment has been minimized.

Sign in to view
Mister-Muffin
Mister-Muffin requested changes Aug 7, 2019
View reviewed changes
Copy link
Owner

@Mister-Muffin Mister-Muffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grafik

@Mister-Muffin
Copy link
Owner

That buttons are visible with the "Enter to Start" screen.

@Mr-Pine
Copy link
Collaborator Author

Mr-Pine commented Aug 7, 2019

Soll ich das machen?

@Mister-Muffin
Copy link
Owner

ja, bitte:+1:

@Mr-Pine
Copy link
Collaborator Author

Mr-Pine commented Aug 7, 2019

Das wäre dann ein issue

@Mr-Pine
Copy link
Collaborator Author

Mr-Pine commented Aug 7, 2019

Braucht man dann das Enter

@Mister-Muffin
Copy link
Owner

Ich fande das ganz nett. Haben andere Spiele ja auch. z.B Hitman2

@Mr-Pine
Copy link
Collaborator Author

Mr-Pine commented Aug 7, 2019

Aber wenn die optionen schon da sind

@Mr-Pine
Copy link
Collaborator Author

Mr-Pine commented Aug 7, 2019

Ich fand das bisher ganz gut

@Mister-Muffin
Copy link
Owner

Ja, ok. Dann blende die Nodes und Code bitte erst nur mal aus. Damit man das nicht nochmal programmieren muss.

@Mr-Pine
Copy link
Collaborator Author

Mr-Pine commented Aug 7, 2019

#32

@Mr-Pine
Copy link
Collaborator Author

Mr-Pine commented Aug 7, 2019

Kannst du approven und mergen?

@Mister-Muffin
Copy link
Owner

Der Bug ins aber ja noch da. Da steht press Enter to start und die Buttons sind da...

@Mister-Muffin
Copy link
Owner

Warte ich löse das problem...

@Mr-Pine
Copy link
Collaborator Author

Mr-Pine commented Aug 7, 2019

Das ist ein bug?

@Mr-Pine
Copy link
Collaborator Author

Mr-Pine commented Aug 7, 2019

ICh dachte du wolltest das

@Mister-Muffin
Copy link
Owner

Mister-Muffin commented Aug 7, 2019 •
edited

?
Jetzt machen wir das mal so. Mann kanns ganz einfach wieder ändern...

@Mister-Muffin Mister-Muffin self-requested a review August 7, 2019 13:10
Mister-Muffin
Mister-Muffin previously approved these changes Aug 7, 2019
View reviewed changes
@Mister-Muffin
Copy link
Owner

Darfst mergen wenn du willst...

@Mister-Muffin
Copy link
Owner

Das ist ein bug?

Ja xD

@Mister-Muffin Mister-Muffin self-requested a review August 7, 2019 13:16
@Mr-Pine
Copy link
Collaborator Author

Mr-Pine commented Aug 7, 2019

Für alles andere bitte neuen Issue

@Mister-Muffin
Copy link
Owner

Für alles andere bitte neuen Issue

Ok

@Mr-Pine
Copy link
Collaborator Author

Mr-Pine commented Aug 7, 2019

Musst nochmal approven
Neuer commit

@Mister-Muffin
Copy link
Owner

Die Animation fehlt?
Wenn man Enter drückt hat sich das doch so ausgeblendet oder?

Mister-Muffin
Mister-Muffin requested changes Aug 7, 2019
View reviewed changes
Copy link
Owner

@Mister-Muffin Mister-Muffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Animation missing!?

@Mister-Muffin Mister-Muffin mentioned this pull request Aug 7, 2019
Closed
@Mr-Pine
Copy link
Collaborator Author

Mr-Pine commented Aug 7, 2019

War dein code

@Mister-Muffin
Copy link
Owner

Jetzt gehts...

@Mister-Muffin
Copy link
Owner

Hä

@Mr-Pine
Copy link
Collaborator Author

Mr-Pine commented Aug 7, 2019

von deinem commit

@Mr-Pine Mr-Pine merged commit 8e94565 into master Aug 7, 2019
Karambolage automation moved this from To Do to Done Aug 7, 2019
@Mr-Pine Mr-Pine deleted the DaKie206 branch August 7, 2019 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mister-Muffin Mister-Muffin Mister-Muffin approved these changes

Assignees

@Mr-Pine Mr-Pine

Labels
enhancement New feature or request
Projects
Karambolage
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mr-Pine @Mister-Muffin