Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mithril-stream: end does not work with more than 1 stream in the chain #2197

Closed
foxdonut opened this issue Jul 23, 2018 · 0 comments
Closed
Labels
Type: Bug For bugs and any other unexpected breakage

Comments

@foxdonut
Copy link

When creating a dependent stream with map(), calling .end(true) on that stream does not work if there is more than 1 stream up the chain.

Expected Behavior

Calling .end(true) on a stream should work when there is more than 1 stream up the chain. See this flyd example and notice that in both cases, "three" is not logged.

Current Behavior

See this same example with mithril-stream, in the second case, "three" is logged when it should not be.

Context

Sometimes when creating a stream that "listens" to another stream, it is desirable at some point in the lifetime of the application to "stop listening". This should be possible using .end(true), even if there is more than 1 stream up the chain.

porsager added a commit to porsager/mithril.js that referenced this issue Aug 8, 2018
@porsager porsager mentioned this issue Aug 23, 2018
11 tasks
@dead-claudia dead-claudia added the Type: Bug For bugs and any other unexpected breakage label Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug For bugs and any other unexpected breakage
Projects
Status: Closed
Development

No branches or pull requests

2 participants