Allow xlink:href to get removed, fix option.value in mock
#1979
Conversation
| @@ -376,15 +376,15 @@ o.spec("attributes", function() { | |||
|
|
|||
| o(a.dom.value).equals("1") | |||
| }) | |||
| o("null becomes the empty string", function() { | |||
| o("null becomes 'null'", function() { | |||
There was a problem hiding this comment.
Why is this behavior desirable? I can't think of a time where you'd want to set "null" as an attribute value.
There was a problem hiding this comment.
I filed #1978 (but closed it for reasons not related to this).
There was a problem hiding this comment.
If you feel strongly enough about it, I can fix it pretty quickly.
(FYI, the mock still needed fixed, though.)
There was a problem hiding this comment.
Actually this is in conflict with #1865 which I'm currently trying to rebase. I had set up on treating null and undefined in vdom indiscriminately as a lack of attribute, see fa53a66#diff-0c7e3694f9865906ffe0847957a6c3a9
I'll bring it up in gitter as well for visibility.
| @@ -954,11 +954,11 @@ o.spec("domMock", function() { | |||
| o(select.selectedIndex).equals(1) | |||
| } | |||
| }) | |||
| o("option.value = null is converted to the empty string", function() { | |||
| o("option.value = null is converted to 'null'", function() { | |||
|
The |
Allow `xlink:href` to get removed, fix `option.value` in mock
Description
Motivation and Context
Just noticed while playing around with some optimization that
xlink:*attributes were being mishandled, but I also noticed thatoption.valuewas incorrect in the mock, so I fixed it.How Has This Been Tested?
Added some new tests and ran them all as usual.
Types of changes
Checklist:
docs/change-log.md