Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node_id limit question? #18

Open
samsonsite1 opened this issue May 10, 2023 · 0 comments
Open

node_id limit question? #18

samsonsite1 opened this issue May 10, 2023 · 0 comments

Comments

@samsonsite1
Copy link

samsonsite1 commented May 10, 2023

Hello,
I'm looking at both VF2 and VF3 libraries, and noticed VF2 node_id is limited to unsigned short, while VF3 is limited to unsigned int.

Is it ok to change VF2 node_id to unsigned int ?

Just out of curiosity, why was node_id limited to unsigned short?
Was this a memory concern or a speed concern?

// VF2
typedef unsigned short node_id;
const node_id NULL_NODE=0xFFFF;

// VF3
typedef uint32_t nodeID_t; /<Type for the id of the nodes in the graph */
const nodeID_t NULL_NODE = (std::numeric_limits<uint32_t>::max)(); /
<Null node value */

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant