Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save button activates with no changes made to MF #443

Closed
JaimeLeon2 opened this issue Aug 14, 2021 · 7 comments
Closed

Save button activates with no changes made to MF #443

JaimeLeon2 opened this issue Aug 14, 2021 · 7 comments
Labels
bug Something isn't working in a officially released version config-changes UI
Milestone

Comments

@JaimeLeon2
Copy link

Describe the bug
MF Connector Save button is activated with no changes made in any config

Steps To Reproduce

  1. Start MF normally. The last mcc file is automatically loaded and the Save button is deactivated.
  2. Click on any Input or Output config line

Expected behavior
The Save button should only be activated when a change is made to any configuration.

Actual behavior
Just clicking on any config without even opening the config wizard activates the Save button and consequently the dialog box reminding the user that there are unsaved changes when exiting MF (when there are none).

Details

  • MobiFlight Version: 9.0.0
  • FlightSim: irrelevant
  • AddOn: irrelevant

Additional context
This is the opposite situation of what happened before, where MF would not activate the Save button after having made changes.

@MobiFlight-Admin
Copy link
Collaborator

@JaimeLeon2 I have started to work on this because there is another issue which is kind of related to this. It is quite some effort to do this nicely, that's why I had not done it first :D but yeah - it is probably time to do it the right away.

@MobiFlight-Admin MobiFlight-Admin added this to the 9.1 milestone Sep 1, 2021
@MobiFlight-Admin MobiFlight-Admin added this to Ready For Departure in MobiFlight 9.2 via automation Sep 1, 2021
@MobiFlight-Admin MobiFlight-Admin added enhancement Improvement of an existing feature UI labels Sep 1, 2021
@MobiFlight-Admin
Copy link
Collaborator

Well actually I was assuming you mean "opening the wizard" and "closing without changing" anything would trigger this, but you are saying that only clicking on the row is enough ... I had not observed that yet.

@MobiFlight-Admin MobiFlight-Admin moved this from Ready For Departure to Cruise Flight in MobiFlight 9.2 Sep 1, 2021
@MobiFlight-Admin
Copy link
Collaborator

I think I have this resolved. OMG = that was a lot of work. :D

@MobiFlight-Admin MobiFlight-Admin moved this from Cruise Flight to Beta Arrival in MobiFlight 9.2 Sep 5, 2021
@MobiFlight-Admin MobiFlight-Admin added 9.0.0.1 config-changes and removed enhancement Improvement of an existing feature labels Sep 5, 2021
@MobiFlight-Admin
Copy link
Collaborator

MobiFlight-Admin commented Sep 5, 2021

I forgot to add the change detection for name and active checkbox for the Input Grid.

MobiFlight-Admin pushed a commit that referenced this issue Sep 5, 2021
@JaimeLeon2
Copy link
Author

Yeah, I updated to 9.0.0.1 tonight and noticed the save button still is activated by merely clicking on any line.

@MobiFlight-Admin
Copy link
Collaborator

Can you test with the latest main branch version? I indeed overlooked something that i fixed after publishing.

@JaimeLeon2
Copy link
Author

Tested with MF 9.0.0.2 and the problem is solved. Thanks.

@MobiFlight-Admin MobiFlight-Admin moved this from Beta Arrival to Release Approach in MobiFlight 9.2 Oct 3, 2021
@MobiFlight-Admin MobiFlight-Admin moved this from Release Approach to Touch Down in MobiFlight 9.2 Nov 2, 2021
@MobiFlight-Admin MobiFlight-Admin added the bug Something isn't working in a officially released version label Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in a officially released version config-changes UI
Projects
No open projects
MobiFlight 9.2
Touch Down
Development

No branches or pull requests

2 participants