Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand the number of analog inputs #526

Closed
Jay737 opened this issue Oct 19, 2021 · 2 comments
Closed

Expand the number of analog inputs #526

Jay737 opened this issue Oct 19, 2021 · 2 comments
Assignees
@wotupfoo
Labels
enhancement Improvement of an existing feature firmware good first issue Good for newcomers
Projects
MobiFlight 9.2
Milestone
9.2

Comments

@Jay737
Copy link

Jay737 commented Oct 19, 2021

Is your feature request related to a problem? Please describe.
Apparently there's only five analog inputs available at the moment.

Describe the solution you'd like
Let's use the full potential of all 16 pins please.
@wotupfoo
Copy link

wotupfoo commented Oct 19, 2021 •
edited
Loading

I looked at the code
.\FirmwareSource\mobiflight\mobiflight.cpp#133

It seems that the MEGA board configuration of...
#define MAX_ANALOG_INPUTS 5
...seems arbitrary (i.e. I can't see why it can't just be changed to 16).
I changed the value and mega,uno,pro compiled just fine.
But I did no testing so I won't post a PR to change it at this time.

@neilenns neilenns mentioned this issue Oct 29, 2021
Closed
@MobiFlight-Admin MobiFlight-Admin added this to the 9.2 milestone Nov 21, 2021
@MobiFlight-Admin MobiFlight-Admin added this to Ready For Departure in MobiFlight 9.2 via automation Nov 21, 2021
@MobiFlight-Admin MobiFlight-Admin moved this from Ready For Departure to Cruise Flight in MobiFlight 9.2 Nov 22, 2021
@MobiFlight-Admin
Copy link
Collaborator

it was arbitray in deed. On the mega we don't have pressing memory restrictions (but we do on the UNO and ProMicro).

What is your use case for the 16 analog inputs?

MobiFlight-Admin pushed a commit that referenced this issue Nov 24, 2021
@DocMoebiuz
#560 - increased pins for mega, uno and micro
461ef5e 
#526 - increased analog pins for mega, uno and micro
@MobiFlight-Admin MobiFlight-Admin moved this from Cruise Flight to Beta Arrival in MobiFlight 9.2 Nov 24, 2021
@DocMoebiuz DocMoebiuz moved this from Beta Arrival to Release Approach in MobiFlight 9.2 Dec 1, 2021
@MobiFlight-Admin MobiFlight-Admin added the enhancement Improvement of an existing feature label Dec 24, 2021
@MobiFlight-Admin MobiFlight-Admin moved this from Release Approach to Touch Down in MobiFlight 9.2 Dec 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wotupfoo wotupfoo

Labels
enhancement Improvement of an existing feature firmware good first issue Good for newcomers
Projects
No open projects
MobiFlight 9.2
Touch Down
Milestone
9.2
Development

No branches or pull requests
4 participants
@MobiFlight-Admin @Jay737 @wotupfoo @DocMoebiuz