Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect update of pin selection combo boxes #643

Closed
GioCC opened this issue Jan 5, 2022 · 1 comment · Fixed by #645
Closed

Incorrect update of pin selection combo boxes #643

GioCC opened this issue Jan 5, 2022 · 1 comment · Fixed by #645
Assignees
@GioCC
Labels
enhancement Improvement of an existing feature UI
Milestone
9.3

Comments

@GioCC
Copy link
Contributor

GioCC commented Jan 5, 2022

Bug Description
When changing values of assigned pins, selection lists of other pins of the same device do not update correctly.

Example below (using an InputShifter for convenience, but the behaviour is the same regardless of the device - not tested on ALL devices but on several ones).

Steps To Reproduce (example)

  1. Initial configuration: used pins 19, 20, 21
    Screen Shot 01-05-22 at 09 32 PM

  2. "Latch" pin is changed to 31.
    Screen Shot 01-05-22 at 09 33 PM 001

  3. Reopening the combo box for a check, 21 appears as free pin [OK].
    (Pin 31 appears as "free"="assignable", because currently assigned [OK])
    Screen Shot 01-05-22 at 09 34 PM

  4. Opening the box for "Clock" pin, 21 does not appear as free but 31 does [EXPECTED: the reverse]
    And so on for other selectors.
    Screen Shot 01-05-22 at 09 34 PM 001

Details

  • MobiFlight Version: 9.2.0

==>Working on a fix, will submit PR shortly.
GioCC added a commit to GioCC/MobiFlight-Connector that referenced this issue Jan 5, 2022
@GioCC
Fix for MobiFlight#643-Incorrect update of pin selection combo boxes
4082999 
TEST VERSION, LIMITED TO LedSegment!
@DocMoebiuz
Copy link
Collaborator

Super cool to see the screen shots!

Yeah the pins don't update on the fly. Only on changing the module.

@DocMoebiuz DocMoebiuz added enhancement Improvement of an existing feature UI labels Jan 11, 2022
@DocMoebiuz DocMoebiuz added this to the 9.3 milestone Jan 11, 2022
@DocMoebiuz DocMoebiuz assigned DocMoebiuz and GioCC and unassigned DocMoebiuz Feb 23, 2022
DocMoebiuz pushed a commit that referenced this issue Feb 26, 2022
@GioCC
Fix for #643-Incorrect update of pin selection combo boxes (#645)
320c917 
* Free pins now update even without having to change a device in between
* Changed pin selection boxes to disallow direct user input
@DocMoebiuz DocMoebiuz linked a pull request Feb 26, 2022 that will close this issue
Fix for #643-Incorrect update of pin selection combo boxes #645
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GioCC GioCC

Labels
enhancement Improvement of an existing feature UI
Projects
No open projects
MobiFlight 9.3
Status: Touchdown
Milestone
9.3
Development

Successfully merging a pull request may close this issue.

Fix for #643-Incorrect update of pin selection combo boxes GioCC/MobiFlight-Connector
2 participants
@GioCC @DocMoebiuz