Only prompt for WASM update if it changed #1601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilenns
commented
Jan 16, 2024
Comment on lines
-170
to
-171
| installedEvents = CalculateMD5(CommunityFolder + $@"\mobiflight-event-module\modules\{WasmEventsTxtFile}"); | ||
| mobiflightEvents = CalculateMD5($@".\MSFS2020-module\mobiflight-event-module\modules\{WasmEventsTxtFile}"); |
There was a problem hiding this comment.
This was causing a crash locally because the file doesn't exist anymore in a normal install. Removed since it's no longer needed.
|
Build for this pull request: |
DocMoebiuz
approved these changes
Jan 25, 2024
DocMoebiuz
pushed a commit
that referenced
this pull request
Feb 5, 2024
DocMoebiuz
added
bug
DocMoebiuz
added a commit
that referenced
this pull request
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1594
WasmModulesAreDifferent()method as a condition of prompting on first launchWasmModulesAreDifferent()so it no longer tests the events.txt file.Path.Combine()to create the path to the wasm moduleTo test this you'll need to delete your
user.configfile for mobiflight, which is located in%localappdata%\MobiFlightand then in one of the gibberish folders with the matching app version.