Add a copy logs command #1623
Merged
Add a copy logs command #1623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilenns
commented
Jan 24, 2024
| @@ -164,6 +164,20 @@ public LogAppenderFile() | |||
| File.Delete(FileName); | |||
| } | |||
|
|
|||
| public void CopyToClipboard() | |||
There was a problem hiding this comment.
I put this here instead of in MainForm.cs so the knowledge of where the file is on disk is contained within the log class.
neilenns
commented
Jan 24, 2024
| @@ -67,10 +68,11 @@ private void InitializeUILanguage() | |||
|
|
|||
| public event EventHandler<ConfigFile> ConfigLoaded; | |||
|
|
|||
| private readonly LogAppenderFile logAppenderFile = new LogAppenderFile(); | |||
There was a problem hiding this comment.
This moved out of InitializeLogging() so it's available in the menu click handler.
neilenns
commented
Jan 24, 2024
| @@ -20,6 +20,7 @@ | |||
| using System.Threading.Tasks; | |||
| using MobiFlight.InputConfig; | |||
| using Newtonsoft.Json; | |||
| using System.IO; | |||
There was a problem hiding this comment.
Required for FileLoadException
|
Build for this pull request: |
DocMoebiuz
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1622
Add a "Copy logs to clipboard" command to the extras menu. Correctly handles the case of no log file being available, or other exceptions that might come up.