Fix issue with loading of OnHold and OnLongRelease config in OUTPUT

[Koseng]

fixes #1689
Since syncFromConfig handles also null input and the whole config is cloned on opening the wizard, the previous code was unecessary and missed the new button config parameters.

I don't understand why new AnalogInputConfig and ButtonInputConfig objects were created. First I wanted to clone the config instead of assigning single parameters, but then I thought why cloning at all?

[github-actions]

Build for this pull request:
MobiFlightConnector.zip

[DocMoebiuz]

fixes #1689 Since syncFromConfig handles also null input and the whole config is cloned on opening the wizard, the previous code was unecessary and missed the new button config parameters.

I don't understand why new AnalogInputConfig and ButtonInputConfig objects were created. First I wanted to clone the config instead of assigning single parameters, but then I thought why cloning at all?

we clone the configs ALWAYS inside the config wizards to make sure that any change made inside the WIzard does not affect the original item. So when you click cancel then we can assure that the original item was not changed. Also it helps us to determine whether anything was changed and if we need to mark the config file as "modified" to enable/disable the save-button in the menu bar accordingly.

[Koseng]

fixes #1689 Since syncFromConfig handles also null input and the whole config is cloned on opening the wizard, the previous code was unecessary and missed the new button config parameters.
I don't understand why new AnalogInputConfig and ButtonInputConfig objects were created. First I wanted to clone the config instead of assigning single parameters, but then I thought why cloning at all?

we clone the configs ALWAYS inside the config wizards to make sure that any change made inside the WIzard does not affect the original item. So when you click cancel then we can assure that the original item was not changed. Also it helps us to determine whether anything was changed and if we need to mark the config file as "modified" to enable/disable the save-button in the menu bar accordingly.

Yeah, that is clear. What I did not understand was, since the behavior is as described, why there was an additional copy of the ButtonConfig in the previous code. So first the clone, then an additional copy, which I removed.

[DocMoebiuz]

i think that was by accident - i think i added the proper cloning just recently.