Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for max number of output shifters #823

Merged
merged 2 commits into from May 30, 2022

Conversation

neilenns
Copy link
Contributor

Fixes #821

  • Add a check for maximum number of output shifters when one is added.
  • Expose the MaxShifters board.json property via the Board class. Somehow this got missed during original implementation!

image

@neilenns neilenns requested a review from DocMoebiuz as a code owner May 30, 2022 16:38
@neilenns
Copy link
Contributor Author

Corrected the error message, uses the right device type now.

image

@DocMoebiuz DocMoebiuz merged commit a18d6c0 into MobiFlight:main May 30, 2022
@DocMoebiuz DocMoebiuz added the bug Something isn't working in a officially released version label Jun 3, 2022
@DocMoebiuz DocMoebiuz added this to the 10.0 milestone Jun 3, 2022
@DocMoebiuz DocMoebiuz added the UI label Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in a officially released version UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Max device limits are not enforced for output shifters
2 participants