Clean up MFBoards.h files to match current values #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilenns
commented
Sep 4, 2021
| @@ -15,7 +15,7 @@ | |||
|
|
|||
| #define MODULE_MAX_PINS 69 | |||
| #define MAX_OUTPUTS 40 | |||
| #define MAX_BUTTONS 67 // 69 max. numbering, 0/1 for serial | |||
| #define MAX_BUTTONS 68 | |||
There was a problem hiding this comment.
neilenns
commented
Sep 4, 2021
| #define MF_LCD_SUPPORT 0 | ||
| #define MF_STEPPER_SUPPORT 0 | ||
| #define MF_SERVO_SUPPORT 0 | ||
| #define MF_SEGMENT_SUPPORT 1 |
There was a problem hiding this comment.
neilenns
commented
Sep 4, 2021
| #define MF_ANALOG_SUPPORT 1 | ||
| #define MF_SHIFTER_SUPPORT 0 | ||
| #define MF_INPUT_SHIFTER_SUPPORT 1 |
There was a problem hiding this comment.
This was an error on my part, accidentally having a #define in the wrong branch.
neilenns
commented
Sep 4, 2021
|
|
||
| // ALL 26892 (93.8%) / 1713 (66.9%) | ||
| // No Segments 25148 (87.7%) / 1580 (61.7%) | ||
| // No LCDs 25308 (88.3%) / 1678 (65.5%) | ||
| // NO Steppers 21892 (76.4%) / 1675 (65.4%) | ||
| // No Servos 25302 (88.2%) / 1620 (63.3%) | ||
|
|
||
| #define MODULE_MAX_PINS 25 | ||
| #define MODULE_MAX_PINS 21 |
There was a problem hiding this comment.
Another error on my part making edits in the wrong branch. This should be 21 as listed here: https://github.dev/MobiFlight/MobiFlight-Connector/blob/51613650fa8142f4a7338633dac631e2ec33fb2a/FirmwareSource/mobiflight/mobiflight.ino#L88
neilenns
commented
Sep 4, 2021
| @@ -25,7 +24,6 @@ | |||
| #define MAX_MFLCD_I2C 2 | |||
| #define MAX_ANALOG_INPUTS 2 | |||
| #define MAX_SHIFTERS 4 | |||
| #define MAX_INPUT_SHIFTERS 4 | |||
There was a problem hiding this comment.
Edits in the wrong branch that carried over.
MobiFlight-Admin
approved these changes
Sep 6, 2021
MobiFlight-Admin
approved these changes
Sep 6, 2021
MobiFlight-Admin
approved these changes
Sep 6, 2021
|
I don't get it. review required, done it three times. what am i missing? |
|
@MobiFlight-Admin Not sure on your end, but on my end it shows you approved and it's ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Founds several places where there were mismatches in MFBoards.h from the source currently checked in to https://github.dev/MobiFlight/MobiFlight-Connector/blob/51613650fa8142f4a7338633dac631e2ec33fb2a/FirmwareSource/mobiflight/mobiflight.ino.
Updated the files so they replicate the currently shipping settings.